[Storage] Add client-side encryption V2 for Queue#24693
Merged
jalauzon-msft merged 16 commits intoAzure:feature/storage-encryption-v2from Jun 9, 2022
Merged
[Storage] Add client-side encryption V2 for Queue#24693jalauzon-msft merged 16 commits intoAzure:feature/storage-encryption-v2from
jalauzon-msft merged 16 commits intoAzure:feature/storage-encryption-v2from
Conversation
jalauzon-msft
requested review from
annatisch,
tasherif-msft and
vincenttran-msft
as code owners
ghost
added
the
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/encryption.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/_shared/encryption.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client.py
Show resolved
Hide resolved
Member
vincenttran-msft
left a comment
vincenttran-msft
left a comment
There was a problem hiding this comment.
Great work and thanks again for tackling this, I really appreciate the work! Everything looks good to me (and great test coverage!!). My comments are mostly suggestions, so take them at your own discretion, and of course if you do take any suggestions just remember to duplicate the change across the several files it is mirrored in (which I often times forget 😛)
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annatisch
reviewed
Jun 8, 2022
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
Looking good to me! Just a few minor things :)
sdk/storage/azure-storage-queue/azure/storage/queue/_queue_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-queue/azure/storage/queue/_shared/base_client.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new version of client-side encryption supporting the use of AES-GCM.