Skip to content

[AutoPR] signalr/resource-manager #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lmazuel merged 6 commits into from
May 7, 2018
Merged

[AutoPR] signalr/resource-manager #2413

lmazuel merged 6 commits into from
May 7, 2018

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Apr 17, 2018

Created to accumulate context: signalr/resource-manager

@AutorestCI AutorestCI requested a review from lmazuel as a code owner April 17, 2018 01:39
This was referenced Apr 17, 2018
Merged
Merged
Merged
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Apr 18, 2018 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-signalr

You can install the package azure-mgmt-signalr of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_signalr/resource-manager#egg=azure-mgmt-signalr&subdirectory=azure-mgmt-signalr"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_signalr/resource-manager#egg=azure-mgmt-signalr&subdirectory=azure-mgmt-signalr"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_signalr/resource-manager
  • pip install -e ./azure-mgmt-signalr

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_signalr/resource-manager
  • pip wheel --no-deps ./azure-mgmt-signalr

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Apr 18, 2018 •
edited
Loading

Codecov Report

Merging #2413 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2413      +/-   ##
==========================================
+ Coverage   55.25%   55.25%   +<.01%     
==========================================
  Files        6486     6488       +2     
  Lines      142518   142520       +2     
==========================================
+ Hits        78752    78754       +2     
  Misses      63766    63766
Impacted Files Coverage Δ
azure-mgmt-signalr/azure/mgmt/__init__.py 100% <100%> (ø)
azure-mgmt-signalr/azure/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247c166...5a076c4. Read the comment docs.

@AutorestCI AutorestCI mentioned this pull request Apr 19, 2018
Merged
@zackliu
Copy link
Member

zackliu commented Apr 20, 2018

@lmazuel Now here is a problem in this PR. #2904 opened but not merged. However, this SDK generated a new version according to #2904. When that PR closed, this SDK didn't revert.
So, the SDK is not consistent with the SWIG now.

This was referenced Apr 23, 2018
Merged
Merged
@lmazuel
Copy link
Member

lmazuel commented May 2, 2018

@zackliu let's rebuild from current master state

@lmazuel
Copy link
Member

lmazuel commented May 2, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/signalr/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

AutorestCI commented May 2, 2018

Nothing to rebuild, this PR is up to date

This was referenced May 3, 2018
Merged
Merged
@lmazuel
Copy link
Member

lmazuel commented May 7, 2018

@AutorestCI rebase

1 similar comment
@lmazuel
Copy link
Member

lmazuel commented May 7, 2018

@AutorestCI rebase

AutorestCI and others added 5 commits May 7, 2018 19:55
@AutorestCI
Generated from 733b00572496e33aefa9ff684d36a109532dfe98 (#2412)
a85d8a0 
add new swagger file and examples for SignalR service
@lmazuel @AutorestCI
Packaging for signalr
481da27
@AutorestCI
[AutoPR signalr/resource-manager] Change operationIds of SignalRServi…
faf9d7e 
…ce from Signalr to SignalR (#2420)

* Generated from 345b940028d40f0b6edba8a86337d1e3290ca3fd

Change operationIds of SignalRService from Signalr to SignalR

* Generated from a30b039762b714c2c40201e5ff5dafe8a1def8fd

revert x-ms-client-name

* Generated from b77be4c2bae1854cea5eccc2ceb25eed8adaf851

Change name SignalR to Signalr for better SDK
@AutorestCI
Generated from 3f725a998dd9e330327ed0bd3609a045c0244a9f (#2448)
f545d13 
finalize the operationIds
@AutorestCI
Generated from fe945cab5ae7da48a881392a7bc8b3fda2ef3748 (#2523)
cfd3aa6 
update CheckNameAvailability resource extra location in its route
@AutorestCI AutorestCI force-pushed the restapi_auto_signalr/resource-manager branch from 38afeb3 to cfd3aa6 Compare May 7, 2018 19:56
@AutorestCI
Copy link
Contributor Author

AutorestCI commented May 7, 2018

Rebase done and pushed to the branch

@lmazuel
Copy link
Member

lmazuel commented May 7, 2018

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/signalr/resource-manager/readme.md

@AutorestCI
Copy link
Contributor Author

AutorestCI commented May 7, 2018

Nothing to rebuild, this PR is up to date

@lmazuel lmazuel merged commit 5c42207 into master May 7, 2018
@lmazuel lmazuel deleted the restapi_auto_signalr/resource-manager branch May 7, 2018 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

ServicePR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AutorestCI @codecov-io @zackliu @lmazuel