Skip to content

Issue #9324 by DaisyCisneros #21824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iscai-msft merged 3 commits into from
Jan 14, 2022
Merged

Issue #9324 by DaisyCisneros #21824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33539ad
Issue #9324: Added an offline version of the test_compress_plain_no_h…
DaisyCisneros Nov 19, 2021
5f9790c
Yielded the value test in streams.py and returned a generator; The re…
DaisyCisneros Dec 4, 2021
9e9d485
Fixing merge conflicts in streams.py.
DaisyCisneros Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions sdk/core/azure-core/tests/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#
# --------------------------------------------------------------------------
import pytest
from azure.core.pipeline.transport import RequestsTransport
from azure.core import PipelineClient
from azure.core.exceptions import DecodeError
from azure.core.pipeline.transport import RequestsTransport
Expand All @@ -44,6 +45,20 @@ def test_decompress_plain_no_header(http_request):
decoded = content.decode('utf-8')
assert decoded == "test"

@pytest.mark.parametrize("http_request", HTTP_REQUESTS)
def test_compress_plain_no_header_offline(port, http_request):
# thanks to Daisy Cisneros for this test!
# expect plain text
request = http_request(method="GET", url="http://localhost:{}/streams/string".format(port))
with RequestsTransport() as sender:
response = sender.send(request, stream=True)
response.raise_for_status()
data = response.stream_download(sender, decompress=False)
content = b"".join(list(data))
decoded = content.decode('utf-8')
assert decoded == "test"

@pytest.mark.live_test_only
@pytest.mark.parametrize("http_request", HTTP_REQUESTS)
def test_compress_plain_no_header(http_request):
# expect plain text
Expand Down
11 changes: 10 additions & 1 deletion ...re/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ def stream_json_error():
yield '{"error": {"code": "BadRequest", '
yield' "message": "You made a bad request"}}'

def streaming_test():
yield b"test"

def stream_compressed_header_error():
yield b'test'

Expand All @@ -40,7 +43,13 @@ def iterable():
def error():
return Response(stream_json_error(), status=400)

@streams_api.route('/string', methods=['GET'])
def string():
return Response(
streaming_test(), status=200, mimetype="text/plain"
)

@streams_api.route('/compressed', methods=['GET'])
def compressed():
return Response(stream_compressed_header_error(), status=300, headers={"Content-Encoding": "gzip"})