Issue #9324 by DaisyCisneros #21824
Merged
Issue #9324 by DaisyCisneros #21824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_no_header test in test_streaming.py by utilizing a new function I added in streams.py. This new test named test_compress_plain_no_header_offline, passes!
ghost
added
Azure.Core
customer-reported
|
Thank you for your contribution DaisyCisneros! We will review the pull request and get back to you soon. |
ghost
added
the
Impact++
|
Thank you for your contribution, DaisyCisneros! |
|
|
Contributor
|
Related issue: #9324 |
iscai-msft
reviewed
Nov 19, 2021
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
overall really great work @DaisyCisneros! Thank you so much for helping us out with this!
sdk/core/azure-core/tests/testserver_tests/coretestserver/coretestserver/test_routes/streams.py
Show resolved
Hide resolved
…sponse is now stream downloaded in test_compress_plain_no_header_offline
kristapratico
approved these changes
Dec 6, 2021
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
@DaisyCisneros this looks great to me! There are some test errors unrelated to your changes that we'll work on getting green! 😎
xiangyan99
approved these changes
Dec 6, 2021
Member
|
Looks great! Thanks for the contribution. |
Contributor
|
@DaisyCisneros can you pull from main? I think once that happens this PR is good to go! |
Contributor
|
/check-enforcer override |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jan 18, 2022
…into add_back_error_message * 'main' of https://github.com/Azure/azure-sdk-for-python: switch error str tests to in (Azure#22016) drop py27 support (Azure#22531) Update TextAnalytics to enable live testing in sovereign clouds for multiple services (Azure#22461) fix: body is too long when create github release (Azure#22522) [AutoRelease] t2-labservices-2022-01-10-05622 (Azure#22401) [ACR] Change to support python3.6 or above only (Azure#22325) Sync eng/common directory with azure-sdk-tools for PR 2554 (Azure#22515) [purview catalog] regen with guids rest name fix (Azure#22495) Migrate EG tests to test proxy (Azure#21772) [Test Proxy] Normalize paths in test IDs (Azure#22508) Add packages to $PackageExclusions which do not build properly in Docs CI (Azure#22493) Update Manifest Publishing (Azure#22476) Issue Azure#9324 by DaisyCisneros (Azure#21824)
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an offline version of the test_compress_plain_no_header test in test_streaming.py by utilizing a new function I added in streams.py. This new test named test_compress_plain_no_header_offline, passes!