Skip to content

aiohttp should not depend on requests #19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 1 commit into from
Jul 23, 2021
Merged

aiohttp should not depend on requests #19808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sdk/core/azure-core/azure/core/pipeline/transport/_aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import codecs
import aiohttp
from multidict import CIMultiDict
from requests.exceptions import StreamConsumedError

from azure.core.configuration import ConnectionConfiguration
from azure.core.exceptions import ServiceRequestError, ServiceResponseError
Expand Down Expand Up @@ -247,8 +246,6 @@ async def __anext__(self):
except _ResponseStopIteration:
internal_response.close()
raise StopAsyncIteration()
except StreamConsumedError:
raise
Copy link
Member

@annatisch annatisch Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be replaced by anything?
....probably not because we were just reraising it, and a requests error never would have been raised by aiohttp anyway.... did aiohttp have an equivalent need to handle?

Copy link
Member Author

@xiangyan99 xiangyan99 Jul 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replacing (if needed) would be a potential breaking change. For this PR, I want to fix the for-sure bad code to unblock the work to cut dependency on requests library. Does this make sense?

except Exception as err:
_LOGGER.warning("Unable to stream download: %s", err)
internal_response.close()
Expand Down