aiohttp should not depend on requests #19808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
|
/azp run python - autorest - pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - appconfiguration - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Jul 23, 2021
| internal_response.close() | ||
| raise StopAsyncIteration() | ||
| except StreamConsumedError: | ||
| raise |
Member
There was a problem hiding this comment.
Does this need to be replaced by anything?
....probably not because we were just reraising it, and a requests error never would have been raised by aiohttp anyway.... did aiohttp have an equivalent need to handle?
Member
Author
There was a problem hiding this comment.
Replacing (if needed) would be a potential breaking change. For this PR, I want to fix the for-sure bad code to unblock the work to cut dependency on requests library. Does this make sense?
annatisch
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.