Skip to content

add samples readme slug analysis #17999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add samples readme slug analysis #17999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions eng/pipelines/templates/steps/analyze.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ steps:
condition: and(succeededOrFailed(), ne(variables['Build.Reason'],'PullRequest'))
displayName: 'Component Detection'

- pwsh: |
Get-ChildItem $(Build.SourcesDirectory)/sdk/${{parameters.ServiceDirectory}} -Filter *.md -Recurse `
| eng/scripts/Find-InvalidSlug.ps1 -IncludeParents
Copy link
Member

@heaths heaths Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into eng/common if we're going to use it across language repos. The step should too.

Copy link
Member

@heaths heaths Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated https://gist.github.com/heaths/08a395af1800a2826be8b8759e735394 with some improvements (no change in desired behavior), including Write-Error instead of Write-Warning. File info is only passed back now if you pass -PassThru - not exactly recommended with the Find standard verb, but 🤷‍♂️.

Copy link
Member

@heaths heaths Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll start a PR. If we're discussing adding more validation, I'm going to rename this to be less-specific to slugs and more general, e.g. Test-SampleMetadata.ps1.

Copy link
Member

@heaths heaths Apr 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Azure/azure-sdk-tools#1555

Copy link
Member

@heaths heaths Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/azure-sdk-tools#1555 has been merged.

displayName: Verify Slugs

- task: PythonScript@0
displayName: 'Verify sdist'
condition: and(succeededOrFailed(), ne(variables['Skip.VerifySdist'],'true'))
Expand Down
Loading