add samples readme slug analysis #17999
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heaths
requested changes
Apr 13, 2021
|
|
||
| - pwsh: | | ||
| Get-ChildItem $(Build.SourcesDirectory)/sdk/${{parameters.ServiceDirectory}} -Filter *.md -Recurse ` | ||
| | eng/scripts/Find-InvalidSlug.ps1 -IncludeParents |
Member
There was a problem hiding this comment.
This should go into eng/common if we're going to use it across language repos. The step should too.
Member
There was a problem hiding this comment.
I updated https://gist.github.com/heaths/08a395af1800a2826be8b8759e735394 with some improvements (no change in desired behavior), including Write-Error instead of Write-Warning. File info is only passed back now if you pass -PassThru - not exactly recommended with the Find standard verb, but 🤷♂️.
Member
There was a problem hiding this comment.
I'll start a PR. If we're discussing adding more validation, I'm going to rename this to be less-specific to slugs and more general, e.g. Test-SampleMetadata.ps1.
heaths
reviewed
Apr 13, 2021
heaths
added a commit
to heaths/azure-sdk-tools
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-android
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-c
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-cpp
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-ios
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-android
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-c
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-cpp
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-ios
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Apr 14, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
azure-sdk
pushed a commit
that referenced
this pull request
Apr 14, 2021
Replaces #17999 for use in all language repos.
azure-sdk
added a commit
to Azure/azure-sdk-for-android
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-c
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-cpp
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-ios
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope * Use verify-samples template Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
to Azure/azure-sdk-for-net
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope * Use verify-sample template Co-authored-by: Heath Stewart <[email protected]>
azure-sdk
added a commit
that referenced
this pull request
Apr 15, 2021
* Verify samples during CIs Replaces #17999 for use in all language repos. * Move exit to proper scope * Use verify-samples template Co-authored-by: Heath Stewart <[email protected]>
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Apr 15, 2021
Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.
benbp
pushed a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Apr 28, 2021
* Verify samples during CIs Replaces Azure/azure-sdk-for-python#17999 for use in all language repos. * Move exit to proper scope Co-authored-by: Heath Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.