Resolve Regression Failures #16455
Resolve Regression Failures #16455
Conversation
…in preperation for deleting generate_doc.py
…which can be treated as an array
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
| run_check_call( | ||
| [ | ||
| "python", | ||
| sys.executable, |
There was a problem hiding this comment.
Discovered when running locally that python calling python doesn't nest properly unless you're using system PATH updates like how the VSAgents do them.
Using sys.executable is the proper way to ensure that you're always in the same environment.
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/check-enforcer override |
…into analyze_redesign * 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) First release purview (Azure#16440) 1ES pools update for release pipeline. (Azure#16419) Add Cloud environment for Teams user (Azure#16359) Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404) ...
…into enum-meta * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) Communication identity api redesign (Azure#16420) fix EH samples and docs (Azure#16457) T2 redisenterprise 2021 02 02 (Azure#16472) Update automation_generate.sh (Azure#16470) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) ...
2 participants
Azure-sdk-tools is no longer installed as part of test_tools.txt.
Given that, a standard regression test will fail unless it's been included in the dev_requirements.txt. Some packages did have that, but the regression uses the code as it was when the package released. There a couple packages that relied on
azure-sdk-toolsbeing present in the test_tools.txt to install it at test run-time. Since we use the newest copy of the regression env, test_tools doesn't include it, and previous tags fail.Just filter it, then include it ourselves.