Nightly publish to dev feed should run regardless of test outcome #15058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
weshaggard
approved these changes
Nov 6, 2020
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
I'm OK with this change although it is a little odd so it is probably worth adding a comment about why this condition is this way.
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Feb 2, 2021
…into analyze_redesign * 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) First release purview (Azure#16440) 1ES pools update for release pipeline. (Azure#16419) Add Cloud environment for Teams user (Azure#16359) Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Feb 2, 2021
…into enum-meta * 'master' of https://github.com/Azure/azure-sdk-for-python: (128 commits) Communication identity api redesign (Azure#16420) fix EH samples and docs (Azure#16457) T2 redisenterprise 2021 02 02 (Azure#16472) Update automation_generate.sh (Azure#16470) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should always run integration to publish from our artifacts. If the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down.
While this doesn't address the chicken/egg problem caused from checking in a version bump of azure-core + a dependency version bump in the same day, it will definitely enable the pipeline to self-mitigate that problem. It'll fail for a night, then resume normal operations the next day.