Skip to content

Conversation

@AutorestCI
Copy link
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1909

@lmazuel
Copy link
Member

lmazuel commented Oct 24, 2017

Replace #1561

@yugangw-msft
Copy link

yugangw-msft commented Oct 24, 2017

@lmazuel, I have spent hours in verifying #1561. To avoid wasted effort, is it fine for you to diff the change with the old one? If the diff is huge, mind to publish #1561 first? That one is important to unblock MSI work

@codecov-io
Copy link

codecov-io commented Oct 24, 2017

Codecov Report

Merging #1569 into master will decrease coverage by 0.27%.
The diff coverage is 37.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1569      +/-   ##
==========================================
- Coverage   54.18%   53.91%   -0.28%     
==========================================
  Files        3595     3605      +10     
  Lines       88698    89300     +602     
==========================================
+ Hits        48065    48143      +78     
- Misses      40633    41157     +524
Impacted Files Coverage Δ
...-web/azure/mgmt/web/models/metric_specification.py 21.05% <ø> (ø) ⬆️
...b/azure/mgmt/web/operations/web_apps_operations.py 5.49% <ø> (-0.01%) ⬇️
...mt-web/azure/mgmt/web/models/continuous_web_job.py 29.41% <ø> (ø) ⬆️
azure-mgmt-web/azure/mgmt/web/models/dimension.py 50% <ø> (ø) ⬆️
...azure/mgmt/web/models/csm_operation_description.py 50% <ø> (ø) ⬆️
azure-mgmt-web/azure/mgmt/web/models/vnet_info.py 41.66% <ø> (ø) ⬆️
...b/azure/mgmt/web/operations/provider_operations.py 21.87% <ø> (ø) ⬆️
azure-mgmt-web/azure/mgmt/web/models/address.py 45.45% <ø> (ø) ⬆️
azure-mgmt-web/azure/mgmt/web/models/web_job.py 35.71% <ø> (ø) ⬆️
...gmt-web/azure/mgmt/web/models/site_seal_request.py 66.66% <ø> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38b3ce0...6f96a4c. Read the comment docs.

@yugangw-msft
Copy link

yugangw-msft commented Oct 24, 2017

@lmazuel, let me verify this one as well, but please note I don't want to do it for 3rd time :)!

@yugangw-msft
Copy link

@lmazuel, verified. Would you please publish it? Thanks!

@lmazuel
Copy link
Member

lmazuel commented Oct 24, 2017

@yugangw-msft sorry I just get your message, I merge this one before another wave is coming :p

@lmazuel lmazuel merged commit 1fcefd0 into Azure:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants