-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Use relative references to models in common definitions json. Remove duplicate models from each swagger collection doc #1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…vice and gateway API
…duplicate models from each swagger collection doc
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
The This causes a code generation change. |
| @@ -15925,7 +15630,7 @@ | |||
| "type": "string", | |||
| "readOnly": true | |||
| }, | |||
| "functionAppId": { | |||
| "function_app_id": { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've changed this. This causes a code generation change.
fearthecowboy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks pretty good.
When I regenerated the code there were just the two changes, those should be fixed before proceeding.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@fearthecowboy Thanks. I have made the requested changes. |
|
I've regenerated both c# and python, and it looks like this doesn't change the generated sdks, which means this is just plain cleanup, and no regeneration or changes to SDKs is required. (there is a cosmetic re-order in a couple python files, but nothing that changes functionality) |
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger