Skip to content

Conversation

@naveedaz
Copy link
Contributor

@naveedaz naveedaz commented Oct 23, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Naveed Aziz added 30 commits May 8, 2017 17:09
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 88
After the PR: Warning(s): 0 Error(s): 88

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@fearthecowboy
Copy link
Contributor

The CloningInfo model in CommonDefinitions is missing the property:

  "ignoreQuotas": {
          "description": "<code>true</code> if quotas should be ignored; otherwise, <code>false</code>.",
          "type": "boolean"
        }

This causes a code generation change.

@@ -15925,7 +15630,7 @@
"type": "string",
"readOnly": true
},
"functionAppId": {
"function_app_id": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've changed this. This causes a code generation change.

Copy link
Contributor

@fearthecowboy fearthecowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good.

When I regenerated the code there were just the two changes, those should be fixed before proceeding.

@fearthecowboy fearthecowboy added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 24, 2017
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/web/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 88
After the PR: Warning(s): 0 Error(s): 88

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@naveedaz
Copy link
Contributor Author

@fearthecowboy Thanks. I have made the requested changes.

@fearthecowboy
Copy link
Contributor

I've regenerated both c# and python, and it looks like this doesn't change the generated sdks, which means this is just plain cleanup, and no regeneration or changes to SDKs is required.

(there is a cosmetic re-order in a couple python files, but nothing that changes functionality)

@fearthecowboy fearthecowboy added Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates and removed Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review labels Oct 24, 2017
@fearthecowboy fearthecowboy merged commit 3522d29 into Azure:current Oct 24, 2017
@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants