Skip to content

[DO NOT MERGE] [For review only] Communication - Phone Number Client redesign #15593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RezaJooyandeh wants to merge 5 commits into from
Closed

[DO NOT MERGE] [For review only] Communication - Phone Number Client redesign #15593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23de449
update new swagger and regenerate
ankitarorabit Nov 26, 2020
4d298e8
regen using correct commandline
ankitarorabit Nov 26, 2020
373d18f
API first draft
ankitarorabit Nov 26, 2020
4cb435b
Samples for the redesign
ankitarorabit Nov 27, 2020
1f1df20
typo
ankitarorabit Nov 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on-administration/azure/communication/administration/_identity/_generated/aio/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

from ._communication_identity_client import CommunicationIdentityClient
from ._communication_identity_client_async import CommunicationIdentityClient
__all__ = ['CommunicationIdentityClient']
6 changes: 3 additions & 3 deletions ...ted/aio/_communication_identity_client.py → ...o/_communication_identity_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
from azure.core import AsyncPipelineClient
from msrest import Deserializer, Serializer

from ._configuration import CommunicationIdentityClientConfiguration
from .operations import CommunicationIdentityOperations
from ._configuration_async import CommunicationIdentityClientConfiguration
from .operations_async import CommunicationIdentityOperations
from .. import models


class CommunicationIdentityClient(object):
"""Azure Communication Identity Service.

:ivar communication_identity: CommunicationIdentityOperations operations
:vartype communication_identity: azure.communication.administration.aio.operations.CommunicationIdentityOperations
:vartype communication_identity: azure.communication.administration.aio.operations_async.CommunicationIdentityOperations
:param endpoint: Auth and Identity endpoint.
:type endpoint: str
"""
Expand Down
0 ...identity/_generated/aio/_configuration.py → ...ty/_generated/aio/_configuration_async.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ity/_generated/aio/operations/__init__.py → ...enerated/aio/operations_async/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
# --------------------------------------------------------------------------

from ._communication_identity_operations import CommunicationIdentityOperations
from ._communication_identity_operations_async import CommunicationIdentityOperations

__all__ = [
'CommunicationIdentityOperations',
Expand Down
26 changes: 9 additions & 17 deletions ...ons/_communication_identity_operations.py → ...ommunication_identity_operations_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from typing import Any, Callable, Dict, Generic, List, Optional, TypeVar
import warnings

from azure.core.exceptions import ClientAuthenticationError, HttpResponseError, ResourceExistsError, ResourceNotFoundError, map_error
from azure.core.exceptions import HttpResponseError, ResourceExistsError, ResourceNotFoundError, map_error
from azure.core.pipeline import PipelineResponse
from azure.core.pipeline.transport import AsyncHttpResponse, HttpRequest

Expand Down Expand Up @@ -54,12 +54,9 @@ async def create(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType["models.CommunicationIdentity"]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))
api_version = "2020-07-20-preview2"
accept = "application/json"

# Construct URL
url = self.create.metadata['url'] # type: ignore
Expand All @@ -74,7 +71,7 @@ async def create(

# Construct headers
header_parameters = {} # type: Dict[str, Any]
header_parameters['Accept'] = self._serialize.header("accept", accept, 'str')
header_parameters['Accept'] = 'application/json'

request = self._client.post(url, query_parameters, header_parameters)
pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
Expand Down Expand Up @@ -109,9 +106,7 @@ async def delete(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType[None]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))
api_version = "2020-07-20-preview2"

Expand Down Expand Up @@ -163,9 +158,7 @@ async def update(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType[None]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))

_body = models.CommunicationIdentityUpdateRequest(tokens_valid_from=tokens_valid_from)
Expand All @@ -192,6 +185,7 @@ async def update(
body_content = self._serialize.body(_body, 'CommunicationIdentityUpdateRequest')
body_content_kwargs['content'] = body_content
request = self._client.patch(url, query_parameters, header_parameters, **body_content_kwargs)

pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
response = pipeline_response.http_response

Expand Down Expand Up @@ -224,15 +218,12 @@ async def issue_token(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType["models.CommunicationIdentityToken"]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))

_body = models.CommunicationTokenRequest(scopes=scopes)
api_version = "2020-07-20-preview2"
content_type = kwargs.pop("content_type", "application/json")
accept = "application/json"

# Construct URL
url = self.issue_token.metadata['url'] # type: ignore
Expand All @@ -249,12 +240,13 @@ async def issue_token(
# Construct headers
header_parameters = {} # type: Dict[str, Any]
header_parameters['Content-Type'] = self._serialize.header("content_type", content_type, 'str')
header_parameters['Accept'] = self._serialize.header("accept", accept, 'str')
header_parameters['Accept'] = 'application/json'

body_content_kwargs = {} # type: Dict[str, Any]
body_content = self._serialize.body(_body, 'CommunicationTokenRequest')
body_content_kwargs['content'] = body_content
request = self._client.post(url, query_parameters, header_parameters, **body_content_kwargs)

pipeline_response = await self._client._pipeline.run(request, stream=False, **kwargs)
response = pipeline_response.http_response

Expand Down
26 changes: 9 additions & 17 deletions ...tion/administration/_identity/_generated/operations/_communication_identity_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from typing import TYPE_CHECKING
import warnings

from azure.core.exceptions import ClientAuthenticationError, HttpResponseError, ResourceExistsError, ResourceNotFoundError, map_error
from azure.core.exceptions import HttpResponseError, ResourceExistsError, ResourceNotFoundError, map_error
from azure.core.pipeline import PipelineResponse
from azure.core.pipeline.transport import HttpRequest, HttpResponse

Expand Down Expand Up @@ -59,12 +59,9 @@ def create(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType["models.CommunicationIdentity"]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))
api_version = "2020-07-20-preview2"
accept = "application/json"

# Construct URL
url = self.create.metadata['url'] # type: ignore
Expand All @@ -79,7 +76,7 @@ def create(

# Construct headers
header_parameters = {} # type: Dict[str, Any]
header_parameters['Accept'] = self._serialize.header("accept", accept, 'str')
header_parameters['Accept'] = 'application/json'

request = self._client.post(url, query_parameters, header_parameters)
pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
Expand Down Expand Up @@ -115,9 +112,7 @@ def delete(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType[None]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))
api_version = "2020-07-20-preview2"

Expand Down Expand Up @@ -170,9 +165,7 @@ def update(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType[None]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))

_body = models.CommunicationIdentityUpdateRequest(tokens_valid_from=tokens_valid_from)
Expand All @@ -199,6 +192,7 @@ def update(
body_content = self._serialize.body(_body, 'CommunicationIdentityUpdateRequest')
body_content_kwargs['content'] = body_content
request = self._client.patch(url, query_parameters, header_parameters, **body_content_kwargs)

pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
response = pipeline_response.http_response

Expand Down Expand Up @@ -232,15 +226,12 @@ def issue_token(
:raises: ~azure.core.exceptions.HttpResponseError
"""
cls = kwargs.pop('cls', None) # type: ClsType["models.CommunicationIdentityToken"]
error_map = {
401: ClientAuthenticationError, 404: ResourceNotFoundError, 409: ResourceExistsError
}
error_map = {404: ResourceNotFoundError, 409: ResourceExistsError}
error_map.update(kwargs.pop('error_map', {}))

_body = models.CommunicationTokenRequest(scopes=scopes)
api_version = "2020-07-20-preview2"
content_type = kwargs.pop("content_type", "application/json")
accept = "application/json"

# Construct URL
url = self.issue_token.metadata['url'] # type: ignore
Expand All @@ -257,12 +248,13 @@ def issue_token(
# Construct headers
header_parameters = {} # type: Dict[str, Any]
header_parameters['Content-Type'] = self._serialize.header("content_type", content_type, 'str')
header_parameters['Accept'] = self._serialize.header("accept", accept, 'str')
header_parameters['Accept'] = 'application/json'

body_content_kwargs = {} # type: Dict[str, Any]
body_content = self._serialize.body(_body, 'CommunicationTokenRequest')
body_content_kwargs['content'] = body_content
request = self._client.post(url, query_parameters, header_parameters, **body_content_kwargs)

pipeline_response = self._client._pipeline.run(request, stream=False, **kwargs)
response = pipeline_response.http_response

Expand Down
Loading