[DO NOT MERGE] [For review only] Communication - Phone Number Client redesign #15593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RezaJooyandeh
changed the title
RezaJooyandeh
changed the title
annatisch
reviewed
Dec 1, 2020
|
|
||
| @distributed_trace | ||
| def list_phone_plan_groups( | ||
| def get_operation( |
Member
There was a problem hiding this comment.
We normally wouldn't expose this directly - rather it would be part of rehydrating a LROPoller.
Are other languages doing a generic get_operation API?
annatisch
reviewed
Dec 1, 2020
| :param reservation_id: The reservation id to get reservation. | ||
| :type reservation_id: str | ||
| :rtype: ~azure.communication.administration.PhoneNumberReservation | ||
| # type: (...) -> ItemPaged[AcquiredPhoneNumbers] |
Member
There was a problem hiding this comment.
This should be ItemPaged[AquiredPhoneNumber]? I don't think we need the collective object?
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Sep 18, 2021
Dev kubernetesconfiguration microsoft.kubernetes configuration 2021 09 01 (Azure#15593) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.KubernetesConfiguration from version common/2021-05-01-preview to version 2021-09-01 * Updates readme * Updates API version in new specs and examples * Extension GA - apiversion 2021-09-01 * Move definitions.json to the correct folder * Add Patch example * Prettier fix * Patch response fix * Avocado fixes * Additional fixes * Fixes for Model and Semantic validations * Additional fixes * Fix patch example * Prettier fix for definitions.json * Readme.md spacing fix * Add AKSIdentity object * Prettier and Lint Diff fixes * Change Patch response to 202, per review * Update Patch response body to adhere to API guidance * Added Suppression for Patch 202 response * Fix linter issues * Fix linter issues * Fix Linter and Model validation errors * Fix ModelValidation and Prettier issues * Move suppression to the GA version * Move suppression to global * Move suppression back to the GA version * Update suppression * Fix errors from SDK generation * Prettier fix * Remove definitions.json and move the defs. into extensions.json * Remove azure-validator Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: nanthi <nanthi@NANTHI01>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.