Skip to content

Python environment is missing when checking change log #12350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 1 commit into from
Jul 2, 2020
Merged

Python environment is missing when checking change log #12350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions eng/pipelines/templates/stages/archetype-python-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ stages:
deploy:
steps:
- checkout: self

- task: UsePythonVersion@0

@weshaggard weshaggard Jul 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is not intuitive based on calling the verify-changelog.yml. IIRC we essentially need to do this as a pre-step anytime we use the shared powershell scripts. So I'd suggest we either do this as part of the script call to ensure it is always done or we eliminate the need to call scripts. From the python repo in our eng/common scripts.

@chidozieononiwu I'm starting to wonder if we should move the scripts for parsing out the language specific metadata into the language repos and just have an extension point in our common scripts. Perhaps instead of passing the language we pass a class or a script file for the particular language.

@praveenkuttappan praveenkuttappan Jul 2, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard I will revisit this one one release is completed for synapse. I think we need to look at broader point of view as you suggested.

@weshaggard weshaggard Jul 2, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if this is just to unblock the current releases then please move forward with it. I thought they were unblocked with your earlier change and this was the follow-up.


- script: |
pip install -r /eng/ci_tools.txt
displayName: 'Setup Python Environment'

- template: /eng/common/pipelines/templates/steps/verify-changelog.yml
parameters:
PackageName: ${{artifact.name}}
Expand Down