Skip to content

Comments

Python environment is missing when checking change log#12350

Merged
praveenkuttappan merged 1 commit intoAzure:masterfrom
praveenkuttappan:verifychangelog
Jul 2, 2020
Merged

Python environment is missing when checking change log#12350
praveenkuttappan merged 1 commit intoAzure:masterfrom
praveenkuttappan:verifychangelog

Conversation

@praveenkuttappan
Copy link
Member

Python CI tools needs to be installed before running script in common tasks

steps:
- checkout: self

- task: UsePythonVersion@0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency is not intuitive based on calling the verify-changelog.yml. IIRC we essentially need to do this as a pre-step anytime we use the shared powershell scripts. So I'd suggest we either do this as part of the script call to ensure it is always done or we eliminate the need to call scripts. From the python repo in our eng/common scripts.

@chidozieononiwu I'm starting to wonder if we should move the scripts for parsing out the language specific metadata into the language repos and just have an extension point in our common scripts. Perhaps instead of passing the language we pass a class or a script file for the particular language.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weshaggard I will revisit this one one release is completed for synapse. I think we need to look at broader point of view as you suggested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if this is just to unblock the current releases then please move forward with it. I thought they were unblocked with your earlier change and this was the follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify change log step in release is failing for nspkg packages

3 participants