Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Adding Log Analytics query capabilities#3008

Merged
RikkiGibson merged 3 commits intoAzure:masterfrom
alexeldeib:loganalytics
Jun 14, 2018
Merged

Adding Log Analytics query capabilities#3008
RikkiGibson merged 3 commits intoAzure:masterfrom
alexeldeib:loganalytics

Conversation

@alexeldeib
Copy link
Contributor

Hi! This PR is to add client generation for the data plane portion of Log Analytics The corresponding treatment to generation the SDK can be found here.

I also wasn't able to find info about some parts of the process like npm release -- looks like there are some dead links around and the adx repo didn't have better info? Looking for some guidance/resources around what my next steps would be to publicly release after review :)

@ghost ghost added the in progress label Jun 14, 2018
@azuresdkci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you bump the minor version on the root package and update the changelog.

@RikkiGibson
Copy link
Member

Ping me at rigibson@microsoft and I can onboard you to our npm publishing flow.

@RikkiGibson
Copy link
Member

BTW, did #3009 basically do some of this work automatically?

@alexeldeib
Copy link
Contributor Author

alexeldeib commented Jun 14, 2018

Oh -- #3009 is because I added azure-sdk-for-node to the azure-rest-spec repo README's sdk generation, as well as here. I can remove it from the other repo, since i'm adding the mapping as part of this PR?

The client code is the same, this PR adds 9 files:

  • package/package-lock.json
  • license file
  • azure.js rollup function
  • test additions (3 files)
  • package_service_mapping
  • readme

@RikkiGibson
Copy link
Member

I think it's good to have it the config in azure-rest-api-specs. Feel free to close #3009 (or I can if you don't have permission).

@RikkiGibson
Copy link
Member

Our generator config is slightly strange, but the gist is that package_service_mapping doesn't really get used by the AutorestCI bot, but swagger_to_sdk_config does get used, and all the configs over in azure-rest-api-specs get used.

@alexeldeib
Copy link
Contributor Author

Got it. Made those fixes, and closed the auto PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants