Add nodejs generation for Operational Insights

[alexeldeib]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3026

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2772

[AutorestCI]

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2064

[AutorestCI]

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

[sarangan12]

@amarzavery Are you ok with this change? This is related to NodeJS SDK

[alexeldeib]

For context, this is related to pull requests 3008 and 3012 in the Node SDK, which add the relevant functionality. Should have provided some explanation 😊

[sergey-shandar]

CI is fixed

[amarzavery]

The management plane package is named as azure-arm-operationalinsights. It can be found here https://github.com/Azure/azure-sdk-for-node/blob/master/lib/services/operationalInsightsManagement/package.json.

Is there a reason to not follow the convention to name it as azure-operationalinsights and name it as azure-loganalytics ?

[alexeldeib]

Operational Insights is old branding. In general I am trying not to produce fresh releases that use old branding, and will migrate older code to the new branding as well. The RP is still microsoft.operationalInsights.

[alexeldeib]

See e.g. Python management cmdlets for same service: https://github.com/Azure/azure-sdk-for-python/tree/master/azure-mgmt-loganalytics

[amarzavery]

sounds good to me.

[amarzavery]

@alexeldeib - Are you doing anything custom in the README.md? Trying to understand why generate-* directives are marked false.
@daschult - Should the generate-* be false?

[alexeldeib]

See also Azure/azure-sdk-for-node#3008 -- I generated using these directives as "true", but I modified the readme examples by hand. I didn't want these overwritten with the generated readme. Does that sound correct, or have I misunderstood the auto-generation here?

I guess that doesn't apply to package-json or license-txt, I can mark these true again.

[alexeldeib]

@amarzavery pulling this out to the top level since I just squashed that comment but see Azure/azure-sdk-for-node#3008

@RikkiGibson for context.