[Peering] create new api version 2020-01-01-preview#9654
Merged
isra-fel merged 1 commit intoAzure:masterfrom Feb 25, 2020
Merged
[Peering] create new api version 2020-01-01-preview#9654isra-fel merged 1 commit intoAzure:masterfrom
isra-fel merged 1 commit intoAzure:masterfrom
Conversation
isra-fel
added
Mgmt
Contributor
Author
|
SPEC PR merged |
isra-fel
requested changes
Feb 11, 2020
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hi @rileymckenna please see my inline comments. Thanks!
sdk/peering/Microsoft.Azure.Management.Peering/src/Microsoft.Azure.Management.Peering.csproj
Outdated
Show resolved
Hide resolved
sdk/peering/Microsoft.Azure.Management.Peering/src/Microsoft.Azure.Management.Peering.csproj
Outdated
Show resolved
Hide resolved
sdk/peering/Microsoft.Azure.Management.Peering/src/Microsoft.Azure.Management.Peering.csproj
Outdated
Show resolved
Hide resolved
sdk/peering/Microsoft.Azure.Management.Peering/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
sdk/peering/Microsoft.Azure.Management.Peering/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
rileymckenna
force-pushed
the
originmaster
branch
from
530468d to
aa5fc8c
Compare
isra-fel
approved these changes
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Registered Asn
Added Legacy Peering filter by Asn
Added filter to peering service countries
Added Sku to peering type
Added type to direct peering enum
Changed how contact details are stored
Added Sku to peering service
Awaiting PR Merge