Fixed ShareClient.GetStatistics() bug #9438
Conversation
seanmcc-msft
requested review from
JoshLove-msft,
KrzysztofCwalina,
amnguye,
pakrym and
tg-msft
as code owners
| /// The approximate size of the data stored in bytes, rounded up to the nearest gigabyte. Note that this value may not include all recently created or recently resized files. | ||
| /// </summary> | ||
| public int ShareUsageBytes { get; internal set; } | ||
| public long ShareUsageInBytes { get; internal set; } |
There was a problem hiding this comment.
One example of this situation from BCL is Array.Length vs Array.LongLength, I'm not sure that we should use the same naming pattern but just FYI.
| /// <summary> | ||
| /// Warning: Share usage may exceed int.MaxValue. Use ShareUsageInBytes instead. | ||
| /// </summary> | ||
| public int ShareUsageBytes { |
There was a problem hiding this comment.
Nit - use [EditorBrowsable(Never)] here so folks don't even see this in intellisense.
| if (ShareUsageInBytes > int.MaxValue) | ||
| { | ||
| #pragma warning disable CA1065 // Do not raise exceptions in unexpected locations | ||
| throw new OverflowException("ShareUsageInBytes exceeds int.MaxValue. Use ShareUsageInBytes instead."); |
There was a problem hiding this comment.
Change to "ShareUsageBytes exceeds int.MaxValue. Use ShareUsageInBytes instead." and move to Constants
| /// <summary> | ||
| /// Creates a new PermissionInfo instance for mocking. | ||
| /// </summary> | ||
| public static ShareStatistics ShareStatistics(int shareUsageBytes) |
There was a problem hiding this comment.
Nit - use [EditorBrowsable(Never)] here so folks don't even see this in intellisense.
| { | ||
| Transport = new MockTransport(mockResponse) | ||
| }; | ||
| ShareClient shareClient = new ShareClient(new Uri(TestConfigDefault.FileServiceEndpoint), shareClientOption); |
There was a problem hiding this comment.
This still needs to be instrumented for the sync/async to work correctly.
|
/azp run net - storage -ci |
|
No pipelines are associated with this pull request. |
|
Nice job team. I’m very grateful to have experienced this process. #PleaseHireMeMicrosoft 🤣 👏🙏 |
5 participants
Resolves #9186