Skip to content

Azure Security Center - Updated IoT Security Solution#8721

Merged
isra-fel merged 6 commits intoAzure:masterfrom
liranc:master
Nov 13, 2019
Merged

Azure Security Center - Updated IoT Security Solution#8721
isra-fel merged 6 commits intoAzure:masterfrom
liranc:master

Conversation

@liranc
Copy link
Copy Markdown
Contributor

@liranc liranc commented Nov 11, 2019

Relevant spec update: Azure/azure-rest-api-specs#7283

@liranc liranc requested a review from erich-wang as a code owner November 11, 2019 09:51
@isra-fel isra-fel self-assigned this Nov 11, 2019
@isra-fel isra-fel added needs-revision Mgmt This issue is related to a management package. and removed needs-revision labels Nov 11, 2019
Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @liranc , could you

  • Write tests for the new APIs
  • Update versions if you are going to release

Thanks

@liranc liranc requested a review from isra-fel November 12, 2019 11:16
@isra-fel isra-fel assigned isra-fel and unassigned liranc Nov 12, 2019
@isra-fel
Copy link
Copy Markdown
Member

@liranc if you re adding new feature please update minor version, and if it involves breaking change please update the major version.

Also the version in .csproj needs to be updated.
Thanks

@liranc
Copy link
Copy Markdown
Contributor Author

liranc commented Nov 13, 2019

@liranc if you re adding new feature please update minor version, and if it involves breaking change please update the major version.

Also the version in .csproj needs to be updated.
Thanks

@isra-fel This update is backward compatibility and only adds functionality.
I've reverted my previous version change and now I've just updated the minor version, so we're at 1.1.0.

Thanks

@isra-fel isra-fel merged commit f7db597 into Azure:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants