Skip to content

Add 'unmaskedIpLoggingStatus' to IotSecuritySolution#7283

Merged
anuchandy merged 4 commits intoAzure:masterfrom
liranc:liran-dev-security-Microsoft.Security-2019-08-01
Nov 6, 2019
Merged

Add 'unmaskedIpLoggingStatus' to IotSecuritySolution#7283
anuchandy merged 4 commits intoAzure:masterfrom
liranc:liran-dev-security-Microsoft.Security-2019-08-01

Conversation

@liranc
Copy link
Contributor

@liranc liranc commented Sep 22, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@liranc liranc added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 22, 2019
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 22, 2019

@AutorestCI
Copy link

AutorestCI commented Sep 22, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8450

@AutorestCI
Copy link

AutorestCI commented Sep 22, 2019

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6275

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from SDK side, feature development is complete, once arm approves, it will be deployed.

@pilor pilor added ARMChangesRequested ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 28, 2019
@anuchandy anuchandy merged commit 6dc8c8d into Azure:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants