Skip to content

Conversation

@nebadr
Copy link
Contributor

@nebadr nebadr commented Oct 29, 2019

LUIS Authoring v3.0-preview APIs

@nebadr nebadr requested a review from AlexGhiondea as a code owner October 29, 2019 15:20
@nebadr nebadr changed the title A nebadr/luis authoringv3.0preview Luis Authoring v3.0-preview Oct 29, 2019
<AssemblyTitle>Microsoft Azure Cognitive Services Language LUIS Authoring</AssemblyTitle>
<Description>Provides API functions for consuming the Microsoft Azure Cognitive Services LUIS Authoring API.</Description>
<Version>3.2.0-preview.1</Version>
<Version>3.8.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a jump -- should this be 3.3.0-preview.1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexGhiondea We got this feedback on our Runtime nuget, that when we release a preview nuget it should be the next .8 version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the comment: #5991 (comment)

Copy link
Member

@weshaggard weshaggard Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks to be based on older versioning guidance. We have been updating our guidance to follow https://github.com/Azure/azure-sdk-for-net/blob/master/doc/dev/Versioning.md. I'd suggest you updating the version to be 3.2.0-preview.2 unless there are enough changes to jump to a new minor version.

@kayousef-zz kayousef-zz merged commit 052040b into Azure:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants