Skip to content

Update LUIS SDK to support APIs v3.0-preview #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 5 commits into from
Apr 30, 2019
Merged

Update LUIS SDK to support APIs v3.0-preview #5991

dsgouda merged 5 commits into from
Apr 30, 2019

Conversation

@moabba
Copy link
Member

@moabba moabba commented Apr 29, 2019 •
edited
Loading

Add generated SDK for the LUIS v3.0-preview APIs
Spec PR Azure/azure-rest-api-specs#5724

dsgouda
dsgouda suggested changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the Nuget package version to 2.8.0-preview since this is a new preview version of the REST API.

@moabba
Copy link
Member Author

moabba commented Apr 29, 2019

Updated the Nuget package version. But why 2.8.0 specifically, why not 3.0.0?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 29, 2019

Updated the Nuget package version. But why 2.8.0 specifically, why not 3.0.0?

Couple of reasons.

  • Whenever RPs are transitioning from one stable version to another (x-1 to x), we ask them to start with a x-1.8.0-preview. This allows them to release an SDK and make some changes if necessary before actually releasing a stable x.0.0 version.
  • If the REST API version is preview, the Nuget package MUST be preview too. Here, the API version seems to be in preview. the next Nuget preview you can work on would be 2.8.0-preview, whenever you are ready to release a stable version you can move to 3.0.0

@dsgouda
Copy link
Contributor

dsgouda commented Apr 29, 2019

@moabba Please join azure org here to kick off the Jenkins build

@moabba
Copy link
Member Author

moabba commented Apr 29, 2019

@moabba Please join azure org here to kick off the Jenkins build

I'm already in the Azure org. How and where can I kick off this build?

@dsgouda dsgouda closed this Apr 29, 2019
@dsgouda dsgouda reopened this Apr 29, 2019
dsgouda
dsgouda suggested changes Apr 29, 2019
View reviewed changes
@moabba moabba closed this Apr 30, 2019
@moabba moabba reopened this Apr 30, 2019
dsgouda
dsgouda suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a minor change

src/SDKs/CognitiveServices/dataPlane/Language/LUIS/Runtime/Properties/AssemblyInfo.cs Outdated

[assembly: AssemblyVersion("2.0.0.0")]
[assembly: AssemblyFileVersion("2.1.0.0")]
[assembly: AssemblyVersion("2.8.0.0")]
Copy link
Contributor

@dsgouda dsgouda Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion remains the same, only AssemblyFileVersion must be bumped for a non-major version bumo

dsgouda
dsgouda approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Apr 30, 2019

Will merge once CIs pass

@moabba
Copy link
Member Author

moabba commented Apr 30, 2019

Will merge once CIs pass

Thanks! Any idea when does the Nuget package get released?

@dsgouda
Copy link
Contributor

dsgouda commented Apr 30, 2019

Will merge once CIs pass

Thanks! Any idea when does the Nuget package get released?

You will have to kick off a Jenkins build to publish the Nuget. Please check the instructions here

@dsgouda dsgouda merged commit b0f4e47 into Azure:master Apr 30, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@moabba @mentat9
Update LUIS SDK to support APIs v3.0-preview (Azure#5991)
86b0a6c 
* Update LUIS SDK to support APIs v3.0-preview

* Update the Nuget package version to 2.8.0-preview

* Update the AssemblyVersion and the package release notes

* Generate the SDK using the default specs

* Revert AssemblyVersion update
@nebadr nebadr mentioned this pull request Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moabba @dsgouda