Skip to content

Turn large or mutable structs back into classes #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pakrym merged 6 commits into from
Oct 17, 2019
Merged

Turn large or mutable structs back into classes #8178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
46fd82e
Turn large mutable structs into classes
pakrym Oct 17, 2019
0e9f1c5
PageInfo
pakrym Oct 17, 2019
863d4bc
Rem tests
pakrym Oct 17, 2019
e047762
More
pakrym Oct 17, 2019
04a1c9d
Bring back some
pakrym Oct 17, 2019
260351e
Reuse method
pakrym Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sdk/storage/Azure.Storage.Blobs/src/AppendBlobClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ protected sealed override BlobBaseClient WithCustomerProvidedKeyCore(CustomerPro
/// a failure occurs.
/// </remarks>
public virtual Response<BlobContentInfo> Create(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
AppendBlobAccessConditions? accessConditions = default,
CancellationToken cancellationToken = default) =>
Expand Down Expand Up @@ -315,7 +315,7 @@ public virtual Response<BlobContentInfo> Create(
/// a failure occurs.
/// </remarks>
public virtual async Task<Response<BlobContentInfo>> CreateAsync(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
AppendBlobAccessConditions? accessConditions = default,
CancellationToken cancellationToken = default) =>
Expand Down Expand Up @@ -355,7 +355,7 @@ await CreateInternal(
/// a failure occurs.
/// </remarks>
public virtual Response<BlobContentInfo> CreateIfNotExists(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
CancellationToken cancellationToken = default) =>
CreateIfNotExistsInternal(
Expand Down Expand Up @@ -393,7 +393,7 @@ public virtual Response<BlobContentInfo> CreateIfNotExists(
/// a failure occurs.
/// </remarks>
public virtual async Task<Response<BlobContentInfo>> CreateIfNotExistsAsync(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
CancellationToken cancellationToken = default) =>
await CreateIfNotExistsInternal(
Expand Down Expand Up @@ -434,7 +434,7 @@ await CreateIfNotExistsInternal(
/// a failure occurs.
/// </remarks>
private async Task<Response<BlobContentInfo>> CreateIfNotExistsInternal(
BlobHttpHeaders? httpHeaders,
BlobHttpHeaders httpHeaders,
Metadata metadata,
bool async,
CancellationToken cancellationToken)
Expand Down Expand Up @@ -502,7 +502,7 @@ private async Task<Response<BlobContentInfo>> CreateIfNotExistsInternal(
/// a failure occurs.
/// </remarks>
private async Task<Response<BlobContentInfo>> CreateInternal(
BlobHttpHeaders? httpHeaders,
BlobHttpHeaders httpHeaders,
Metadata metadata,
AppendBlobAccessConditions? accessConditions,
bool async,
Expand Down
6 changes: 3 additions & 3 deletions sdk/storage/Azure.Storage.Blobs/src/BlobBaseClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2411,7 +2411,7 @@ private async Task<Response<BlobProperties>> GetPropertiesInternal(
/// a failure occurs.
/// </remarks>
public virtual Response<BlobInfo> SetHttpHeaders(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
BlobAccessConditions? accessConditions = default,
CancellationToken cancellationToken = default) =>
SetHttpHeadersInternal(
Expand Down Expand Up @@ -2447,7 +2447,7 @@ public virtual Response<BlobInfo> SetHttpHeaders(
/// a failure occurs.
/// </remarks>
public virtual async Task<Response<BlobInfo>> SetHttpHeadersAsync(
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
BlobAccessConditions? accessConditions = default,
CancellationToken cancellationToken = default) =>
await SetHttpHeadersInternal(
Expand Down Expand Up @@ -2486,7 +2486,7 @@ await SetHttpHeadersInternal(
/// a failure occurs.
/// </remarks>
private async Task<Response<BlobInfo>> SetHttpHeadersInternal(
BlobHttpHeaders? httpHeaders,
BlobHttpHeaders httpHeaders,
BlobAccessConditions? accessConditions,
bool async,
CancellationToken cancellationToken)
Expand Down
20 changes: 10 additions & 10 deletions sdk/storage/Azure.Storage.Blobs/src/BlobClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ public virtual Task<Response<BlobContentInfo>> UploadAsync(
#pragma warning restore AZC0002 // Client method should have cancellationToken as the last optional parameter

/// <summary>
/// The <see cref="Upload(Stream, BlobHttpHeaders?, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// The <see cref="Upload(Stream, BlobHttpHeaders, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// operation creates a new block blob or updates the content of an
/// existing block blob. Updating an existing block blob overwrites
/// any existing metadata on the blob.
Expand Down Expand Up @@ -490,7 +490,7 @@ public virtual Task<Response<BlobContentInfo>> UploadAsync(
[ForwardsClientCalls]
public virtual Response<BlobContentInfo> Upload(
Stream content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
IProgress<StorageProgress> progressHandler = default,
Expand All @@ -510,7 +510,7 @@ public virtual Response<BlobContentInfo> Upload(
.EnsureCompleted();

/// <summary>
/// The <see cref="Upload(FileInfo, BlobHttpHeaders?, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// The <see cref="Upload(FileInfo, BlobHttpHeaders, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// operation creates a new block blob or updates the content of an
/// existing block blob. Updating an existing block blob overwrites
/// any existing metadata on the blob.
Expand Down Expand Up @@ -563,7 +563,7 @@ public virtual Response<BlobContentInfo> Upload(
[ForwardsClientCalls]
public virtual Response<BlobContentInfo> Upload(
FileInfo content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
IProgress<StorageProgress> progressHandler = default,
Expand All @@ -583,7 +583,7 @@ public virtual Response<BlobContentInfo> Upload(
.EnsureCompleted();

/// <summary>
/// The <see cref="UploadAsync(Stream, BlobHttpHeaders?, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// The <see cref="UploadAsync(Stream, BlobHttpHeaders, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// operation creates a new block blob or updates the content of an
/// existing block blob. Updating an existing block blob overwrites
/// any existing metadata on the blob.
Expand Down Expand Up @@ -636,7 +636,7 @@ public virtual Response<BlobContentInfo> Upload(
[ForwardsClientCalls]
public virtual Task<Response<BlobContentInfo>> UploadAsync(
Stream content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
IProgress<StorageProgress> progressHandler = default,
Expand All @@ -655,7 +655,7 @@ public virtual Task<Response<BlobContentInfo>> UploadAsync(
cancellationToken: cancellationToken);

/// <summary>
/// The <see cref="UploadAsync(FileInfo, BlobHttpHeaders?, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// The <see cref="UploadAsync(FileInfo, BlobHttpHeaders, Metadata, BlobAccessConditions?, IProgress{StorageProgress}, AccessTier?, ParallelTransferOptions, CancellationToken)"/>
/// operation creates a new block blob or updates the content of an
/// existing block blob. Updating an existing block blob overwrites
/// any existing metadata on the blob.
Expand Down Expand Up @@ -708,7 +708,7 @@ public virtual Task<Response<BlobContentInfo>> UploadAsync(
[ForwardsClientCalls]
public virtual Task<Response<BlobContentInfo>> UploadAsync(
FileInfo content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
IProgress<StorageProgress> progressHandler = default,
Expand Down Expand Up @@ -778,7 +778,7 @@ public virtual Task<Response<BlobContentInfo>> UploadAsync(
/// </remarks>
internal async Task<Response<BlobContentInfo>> StagedUploadAsync(
Stream content,
BlobHttpHeaders? blobHttpHeaders,
BlobHttpHeaders blobHttpHeaders,
Metadata metadata,
BlobAccessConditions? blobAccessConditions,
IProgress<StorageProgress> progressHandler,
Expand Down Expand Up @@ -952,7 +952,7 @@ Task<Response<BlobContentInfo>> CommitBlockListAsync(
/// </remarks>
internal async Task<Response<BlobContentInfo>> StagedUploadAsync(
FileInfo file,
BlobHttpHeaders? blobHttpHeaders,
BlobHttpHeaders blobHttpHeaders,
Metadata metadata,
BlobAccessConditions? blobAccessConditions,
IProgress<StorageProgress> progressHandler,
Expand Down
12 changes: 6 additions & 6 deletions sdk/storage/Azure.Storage.Blobs/src/BlockBlobClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ protected sealed override BlobBaseClient WithCustomerProvidedKeyCore(CustomerPro
/// </remarks>
public virtual Response<BlobContentInfo> Upload(
Stream content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
AccessTier? accessTier = default,
Expand Down Expand Up @@ -433,7 +433,7 @@ public virtual Response<BlobContentInfo> Upload(
/// </remarks>
public virtual async Task<Response<BlobContentInfo>> UploadAsync(
Stream content,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
AccessTier? accessTier = default,
Expand Down Expand Up @@ -502,7 +502,7 @@ await UploadInternal(
/// </remarks>
internal async Task<Response<BlobContentInfo>> UploadInternal(
Stream content,
BlobHttpHeaders? blobHttpHeaders,
BlobHttpHeaders blobHttpHeaders,
Metadata metadata,
BlobAccessConditions? blobAccessConditions,
AccessTier? accessTier,
Expand Down Expand Up @@ -1145,7 +1145,7 @@ private async Task<Response<BlockInfo>> StageBlockFromUriInternal(
/// </remarks>
public virtual Response<BlobContentInfo> CommitBlockList(
IEnumerable<string> base64BlockIds,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
AccessTier? accessTier = default,
Expand Down Expand Up @@ -1212,7 +1212,7 @@ public virtual Response<BlobContentInfo> CommitBlockList(
/// </remarks>
public virtual async Task<Response<BlobContentInfo>> CommitBlockListAsync(
IEnumerable<string> base64BlockIds,
BlobHttpHeaders? httpHeaders = default,
BlobHttpHeaders httpHeaders = default,
Metadata metadata = default,
BlobAccessConditions? accessConditions = default,
AccessTier? accessTier = default,
Expand Down Expand Up @@ -1282,7 +1282,7 @@ await CommitBlockListInternal(
/// </remarks>
internal async Task<Response<BlobContentInfo>> CommitBlockListInternal(
IEnumerable<string> base64BlockIds,
BlobHttpHeaders? blobHttpHeaders,
BlobHttpHeaders blobHttpHeaders,
Metadata metadata,
BlobAccessConditions? blobAccessConditions,
AccessTier? accessTier,
Expand Down
Loading