Skip to content

New sdk version 2019-08-08-preview for azure stack srp #7479

Merged
isra-fel merged 7 commits intoAzure:masterfrom
wenjlu-lgy:master
Sep 19, 2019
Merged

New sdk version 2019-08-08-preview for azure stack srp #7479
isra-fel merged 7 commits intoAzure:masterfrom
wenjlu-lgy:master

Conversation

@wenjlu-lgy
Copy link
Contributor

@wenjlu-lgy wenjlu-lgy commented Sep 5, 2019

@wenjlu-lgy
Copy link
Contributor Author

@deathly809 Could you help to review it?

@isra-fel isra-fel self-assigned this Sep 6, 2019
@isra-fel isra-fel added Mgmt This issue is related to a management package. needs-review labels Sep 6, 2019
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wenjlu-lgy , please

  1. Add the link to swagger review(s) in description
  2. Make sure to check in the eng\mgmt\mgmtmetadata\<rpName>.txt (details)
  3. Update AssemblyVersion in AssemblyInfo.cs
  4. And see my inline comment

Thanks

Copy link
Member

@bganapa bganapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bganapa
Copy link
Member

bganapa commented Sep 18, 2019

@isra-fel Since this is a new api-version, do we need to update the major version for the dll like 1.0.1-preview ? Do you have any strict guidance here?

@isra-fel
Copy link
Member

isra-fel commented Sep 19, 2019

@isra-fel Since this is a new api-version, do we need to update the major version for the dll like 1.0.1-preview ? Do you have any strict guidance here?

@bganapa That's right, thanks for mentioning.
Short answer is, your next version should be 1.9.0-preview.
You can find the detailed guide here: https://github.com/Azure/azure-sdk-for-net/blob/master/Documentation/ExistingManagementSDKVersioning.md

@wenjlu-lgy please change the versions, thanks!

@wenjlu-lgy
Copy link
Contributor Author

@isra-fel Since this is a new api-version, do we need to update the major version for the dll like 1.0.1-preview ? Do you have any strict guidance here?

@bganapa That's right, thanks for mentioning.
Short answer is, your next version should be 1.9.0-preview.
You can find the detailed guide here: https://github.com/Azure/azure-sdk-for-net/blob/master/Documentation/ExistingManagementSDKVersioning.md

@wenjlu-lgy please change the versions, thanks!

Changed.

@isra-fel isra-fel closed this Sep 19, 2019
@isra-fel isra-fel reopened this Sep 19, 2019
@isra-fel isra-fel merged commit 7a17559 into Azure:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants