Generate storage admin spec for 2019-08-08#6957
Generate storage admin spec for 2019-08-08#6957Juliehzl merged 19 commits intoAzure:masterfrom wenjlu-lgy:master
Conversation
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
...ion/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/quotas.json
Outdated
Show resolved
Hide resolved
...ion/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/quotas.json
Outdated
Show resolved
Hide resolved
...n/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/settings.json
Outdated
Show resolved
Hide resolved
...n/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/settings.json
Outdated
Show resolved
Hide resolved
...n/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/settings.json
Outdated
Show resolved
Hide resolved
...sadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/acquisitions.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Outdated
Show resolved
Hide resolved
|
@bganapa @deathly809 @martabarillas Could you help to review the spec for new azure stack srp? |
|
@wenjlu-lgy When you resolve all the change request, you can request @ryansbenson review again. When ARM sign off, I will review swagger spec for you. Another thing to note is you need to resolve conflicts and make CI check passed. |
|
@ryansbenson I've resolved all the comments, could you help to review it again? |
...sadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/acquisitions.json
Show resolved
Hide resolved
...sadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/acquisitions.json
Show resolved
Hide resolved
...n/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/settings.json
Outdated
Show resolved
Hide resolved
...n/azsadmin/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/settings.json
Outdated
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Show resolved
Hide resolved
...min/resource-manager/storage/Microsoft.Storage.Admin/preview/2019-08-08/storageaccounts.json
Show resolved
Hide resolved
|
@wenjlu-lgy Also please have a look at CI check errors. |
|
@Juliehzl CI check errors are fixed. |
|
Hi @Juliehzl what's status of this PR? is it ok to merge? if yes, could you pls merge it? |
|
Waiting for ARM signed off.
|
|
@ryansbenson Could you help to take a look? |
KrisBash
left a comment
There was a problem hiding this comment.
ARM comments appear to be resolved
|
@Juliehzl ARM team has already signed off. Could you help to review it? |
@wenjlu-lgy Definitely. Meanwhile can you try to make CI pass? |
@Juliehzl Done. |
|
@wenjlu-lgy Your swagger specification looks good in general. But out of curiosity, what is the difference between Storage and Storage.Admin Service Provider? |
Storage.Admin is for admin scenario and Storage is for tenant scenario. There are some operations which can only be done by administrator only (like list storage accounts from all tenants). |
@Juliehzl Any other concern about the pr? |
|
@wenjlu-lgy Thanks for your explanation. Approved. |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.