Skip to content

Generate storage admin spec for 2019-08-08#6957

Merged
Juliehzl merged 19 commits intoAzure:masterfrom
wenjlu-lgy:master
Sep 15, 2019
Merged

Generate storage admin spec for 2019-08-08#6957
Juliehzl merged 19 commits intoAzure:masterfrom
wenjlu-lgy:master

Conversation

@wenjlu-lgy
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 14, 2019

In Testing, Please Ignore

[Logs] (Generated from be27ac2, Iteration 12)

No readme.md specification configuration files were found that are associated with the files modified in this pull request.

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 14, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@Juliehzl Juliehzl assigned Juliehzl and unassigned Juliehzl Aug 14, 2019
@Juliehzl Juliehzl added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 14, 2019
@wenjlu-lgy
Copy link
Contributor Author

@bganapa @deathly809 @martabarillas Could you help to review the spec for new azure stack srp?

@Juliehzl
Copy link
Contributor

@wenjlu-lgy When you resolve all the change request, you can request @ryansbenson review again. When ARM sign off, I will review swagger spec for you. Another thing to note is you need to resolve conflicts and make CI check passed.

@wenjlu-lgy
Copy link
Contributor Author

@ryansbenson I've resolved all the comments, could you help to review it again?

Copy link
Member

@deathly809 deathly809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Juliehzl
Copy link
Contributor

@wenjlu-lgy Also please have a look at CI check errors.

@wenjlu-lgy
Copy link
Contributor Author

@Juliehzl CI check errors are fixed.

@yungezz
Copy link
Member

yungezz commented Aug 28, 2019

Hi @Juliehzl what's status of this PR? is it ok to merge? if yes, could you pls merge it?

@Juliehzl
Copy link
Contributor

Waiting for ARM signed off.

Hi @Juliehzl what's status of this PR? is it ok to merge? if yes, could you pls merge it?

@wenjlu-lgy
Copy link
Contributor Author

@ryansbenson Could you help to take a look?

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 6, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM comments appear to be resolved

@wenjlu-lgy
Copy link
Contributor Author

@Juliehzl ARM team has already signed off. Could you help to review it?

@Juliehzl
Copy link
Contributor

@Juliehzl ARM team has already signed off. Could you help to review it?

@wenjlu-lgy Definitely. Meanwhile can you try to make CI pass?

@wenjlu-lgy
Copy link
Contributor Author

@Juliehzl ARM team has already signed off. Could you help to review it?

@wenjlu-lgy Definitely. Meanwhile can you try to make CI pass?

@Juliehzl Done.

@Juliehzl
Copy link
Contributor

@wenjlu-lgy Your swagger specification looks good in general. But out of curiosity, what is the difference between Storage and Storage.Admin Service Provider?

@wenjlu-lgy
Copy link
Contributor Author

@wenjlu-lgy Your swagger specification looks good in general. But out of curiosity, what is the difference between Storage and Storage.Admin Service Provider?

Storage.Admin is for admin scenario and Storage is for tenant scenario. There are some operations which can only be done by administrator only (like list storage accounts from all tenants).

@wenjlu-lgy
Copy link
Contributor Author

@wenjlu-lgy Your swagger specification looks good in general. But out of curiosity, what is the difference between Storage and Storage.Admin Service Provider?

Storage.Admin is for admin scenario and Storage is for tenant scenario. There are some operations which can only be done by administrator only (like list storage accounts from all tenants).

@Juliehzl Any other concern about the pr?

@Juliehzl
Copy link
Contributor

@wenjlu-lgy Thanks for your explanation. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants