SDK update for Soft Delete feature#7338
Merged
isra-fel merged 2 commits intoAzure:masterfrom Aug 23, 2019
SanjayHukumRana:master
Merged
SDK update for Soft Delete feature#7338isra-fel merged 2 commits intoAzure:masterfrom SanjayHukumRana:master
isra-fel merged 2 commits intoAzure:masterfrom
SanjayHukumRana:master
Conversation
Updating SDK for soft delete properties of protected Item
Contributor
|
Can one of the admins verify this patch? |
isra-fel
suggested changes
Aug 21, 2019
Member
isra-fel
left a comment
isra-fel
left a comment
There was a problem hiding this comment.
Hello @SanjayHukumRana , please
- follow the instructions here when generating SDK. Remember to track the .txt file, update versions and tags, etc.
- put a link to the spec review PR in comments
Contributor
Author
|
rest api spec closed PR: Azure/azure-rest-api-specs#6818 From reviewer comment: follow the instructions here when generating SDK. |
Member
|
Sorry about that. Now as a member of Azure orgnization you should be able to view the link and update the PR |
Taken care of PR comments
Contributor
Author
|
Updated PR based on the instructions here. |
isra-fel
approved these changes
Aug 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating SDK for soft delete properties of protected Item