Skip to content

Conversation

@matthchr
Copy link
Member

@matthchr matthchr commented Aug 6, 2019

  • Regenerate Batch Management SDK based on the 2019-08-01
    version of the Swagger specification.

@matthchr matthchr requested a review from erich-wang as a code owner August 6, 2019 22:27
@matthchr matthchr requested review from bgklein and xingwu1 August 6, 2019 22:28
@erich-wang erich-wang self-assigned this Aug 7, 2019
Copy link
Member

@erich-wang erich-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthchr , could you

  1. Provide swagger spec PR related to this change, so that I can tell whether swagger PR is merged?
  2. Follow the instruction for generating this PR? I did not see ``rp-resource-manager.txt` and update for AssemblyFileVersion

@matthchr matthchr force-pushed the feature/batch-management-9.0 branch from 6ed447f to 12bec1d Compare August 7, 2019 16:27
@matthchr
Copy link
Member Author

matthchr commented Aug 7, 2019

Swagger specification is here: Azure/azure-rest-api-specs#6723

I pushed an update where I used generate.ps1 rather than generate.cmd -- is there a reason there are two ways to generate SDKs...?

  - Regenerate Batch Management SDK based on the 2019-08-01
    version of the Swagger specification.
@matthchr matthchr force-pushed the feature/batch-management-9.0 branch from 12bec1d to 2ef1ca3 Compare August 7, 2019 16:31
@matthchr matthchr requested a review from erich-wang August 7, 2019 19:47
@erich-wang
Copy link
Member

Swagger specification is here: Azure/azure-rest-api-specs#6723

I pushed an update where I used generate.ps1 rather than generate.cmd -- is there a reason there are two ways to generate SDKs...?

You should use generate.ps1, delete generate.cmd if have.

@erich-wang erich-wang merged commit 2270a99 into Azure:master Aug 8, 2019
pull bot pushed a commit to test-repo-billy/azure-sdk-for-net that referenced this pull request Aug 8, 2019
* Regenerate Batch Management SDK

  - Regenerate Batch Management SDK based on the 2019-08-01
    version of the Swagger specification.

* Re-record Batch Management tests
@matthchr matthchr deleted the feature/batch-management-9.0 branch August 8, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants