Skip to content

Conversation

@xingwu1
Copy link
Member

@xingwu1 xingwu1 commented Jul 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@xingwu1 xingwu1 requested a review from matthchr as a code owner July 25, 2019 03:00
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 25, 2019

SDK Automation [Logs] (Generated from 4b9ce59, Iteration 9)

Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Succeeded Python: Azure/azure-sdk-for-python [Logs] [Diff]
Failed Java: Azure/azure-sdk-for-java [Logs] [Diff]
Succeeded Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jul 25, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#6484

@AutorestCI
Copy link

AutorestCI commented Jul 25, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5337

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ghost
Copy link

ghost commented Jul 25, 2019

@OpenAPIBot sdkautomation rebuild

@PhoenixHe-NV
Copy link

@OpenAPIBot sdkautomation rebuild

@amarzavery amarzavery added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 29, 2019
@xingwu1
Copy link
Member Author

xingwu1 commented Jul 30, 2019

Can any from ARM team review it?

@majastrz
Copy link
Member

majastrz commented Jul 31, 2019

"version": "2019-08-01.10.0",

This is not a valid API version format. You should set this to 2019-08-01 and also rename the folder to 2019-08-01. #Closed


Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 4b9ce59. [](commit_id = 4b9ce59, deletion_comment = False)

@majastrz
Copy link
Member

"version": "2019-08-01.10.0",

The valid format looks like YYYY-MM-DD with an optional suffix like -preview, -alpha, -beta, -rc, or -privatepreview. No other formats are allowed by ARM.


In reply to: 516665304 [](ancestors = 516665304)


Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 0e07fef. [](commit_id = 0e07fef, deletion_comment = False)

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using an unsupported API version format. I added a comment around it. Please fix that. Everything else seems good from ARM side.

@majastrz
Copy link
Member

"version": "2019-08-01.10.0",

Sorry I didn't realize this was a data plane API, which does not follow those rules.


In reply to: 516665883 [](ancestors = 516665883,516665304)


Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 4b9ce59. [](commit_id = 4b9ce59, deletion_comment = False)

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2019
@xingwu1
Copy link
Member Author

xingwu1 commented Jul 31, 2019

@amarzavery could you merge our spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants