-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Batch] new data plane and mangement plane version 2019-08-01 #6723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SDK Automation [Logs] (Generated from 4b9ce59, Iteration 9)
|
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goA PR has been created for you: |
|
Can one of the admins verify this patch? |
|
@OpenAPIBot sdkautomation rebuild |
|
@OpenAPIBot sdkautomation rebuild |
|
Can any from ARM team review it? |
This is not a valid API version format. You should set this to Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 4b9ce59. [](commit_id = 4b9ce59, deletion_comment = False) |
The valid format looks like YYYY-MM-DD with an optional suffix like -preview, -alpha, -beta, -rc, or -privatepreview. No other formats are allowed by ARM. In reply to: 516665304 [](ancestors = 516665304) Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 0e07fef. [](commit_id = 0e07fef, deletion_comment = False) |
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using an unsupported API version format. I added a comment around it. Please fix that. Everything else seems good from ARM side.
Sorry I didn't realize this was a data plane API, which does not follow those rules. In reply to: 516665883 [](ancestors = 516665883,516665304) Refers to: specification/batch/data-plane/Microsoft.Batch/stable/2019-08-01.10.0/BatchService.json:5 in 4b9ce59. [](commit_id = 4b9ce59, deletion_comment = False) |
majastrz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@amarzavery could you merge our spec? |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.