Closed
Conversation
Updates on Generated Code and New Tests added in .Net SDK
erich-wang
suggested changes
Jul 2, 2019
| <PackageReference Include="Microsoft.Azure.Management.ResourceManager.Fluent" Version="1.22.2" /> | ||
| <PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.TestFramework" Version="1.7.6" /> | ||
| <PackageReference Include="xunit" Version="2.3.1" /> | ||
| </ItemGroup> |
Member
There was a problem hiding this comment.
Line 24,25 and 27 are unnecessary because they are included in AzSdk.test.reference.targets
| <TargetFrameworks>$(SdkTargetFx)</TargetFrameworks> | ||
| <SignAssembly>false</SignAssembly> | ||
| </PropertyGroup> | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Line 14 specifies the PackageReleaseNotes. I will fix the intendation though.
| @@ -0,0 +1,7 @@ | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
Member
There was a problem hiding this comment.
Comments from management plane perspective:
- All the files should be put in sdk instead of src/SDKs because of structure refactoring
- Use lower case heaalthcareapis for folder name of this service
- The folder name and project names should start with Microsoft.Azure.
erich-wang
reviewed
Jul 3, 2019
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(SdkTargetFx)</TargetFrameworks> | ||
| <SignAssembly>false</SignAssembly> |
Member
|
@poadhika, please close this PR and create two separate PRs for data plane and management plane respectively, please also address all comments for management plane. |
erich-wang
reviewed
Jul 3, 2019
| <OutputType>Library</OutputType> | ||
| <StartupObject /> | ||
| </PropertyGroup> | ||
|
|
erich-wang
reviewed
Jul 3, 2019
| <OutputPath>bin\Debug\</OutputPath> | ||
| <DocumentationFile>obj\Debug\netcoreapp2.0\HealthcareApis.Tests.xml</DocumentationFile> | ||
| </PropertyGroup> | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding HealthcareApis into Azure SDK.
This PR comprises of new modules for HealthcareApis that is used to manage HealthcareApis accounts such as (Get/Create/Update/Delete)
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
REST spec PR: Azure/azure-rest-api-specs-pr:
Azure/azure-rest-api-specs#5096
Azure/azure-rest-api-specs#6244