Skip to content

Adding swagger spec for healthcareapis resource manager and examples.#5096

Merged
anuchandy merged 6 commits intoAzure:masterfrom
YazanMSFT:master
Mar 21, 2019
Merged

Adding swagger spec for healthcareapis resource manager and examples.#5096
anuchandy merged 6 commits intoAzure:masterfrom
YazanMSFT:master

Conversation

@YazanMSFT
Copy link
Contributor

@YazanMSFT YazanMSFT commented Jan 25, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Jan 25, 2019

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1700

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4354

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@azuresdkci azuresdkci requested a review from anuchandy January 25, 2019 21:52
@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5014

@AutorestCI
Copy link

AutorestCI commented Jan 25, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3167

@azuresdkci
Copy link
Contributor

azuresdkci commented Jan 25, 2019

Can one of the admins verify this patch?

@ryansbenson ryansbenson added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReviewInProgress labels Jan 25, 2019
ryansbenson
ryansbenson reviewed Jan 26, 2019
View reviewed changes
@ryansbenson ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2019
anuchandy
anuchandy requested changes Feb 2, 2019
View reviewed changes
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YazanMSFT please add readme.md to the PR. here is an example: https://github.com/Azure/azure-rest-api-specs/tree/master/specification/hanaonazure/resource-manager

@anuchandy
Copy link
Member

anuchandy commented Feb 27, 2019

@YazanMSFT could you take a look at my last comment?

@YazanMSFT
Copy link
Contributor Author

YazanMSFT commented Feb 27, 2019

Will do

This was referenced Mar 7, 2019
Closed
Closed
Merged
Closed
This was referenced Mar 12, 2019
Closed
Closed
Merged
@YazanMSFT
Copy link
Contributor Author

YazanMSFT commented Mar 18, 2019

@anuchandy net SDK is failing with an error about not being able to handle a new RP. What needs to be done to resolve this?

@anuchandy
Copy link
Member

anuchandy commented Mar 20, 2019

@YazanMSFT I'm following with .NET team on this.

@anuchandy
Copy link
Member

anuchandy commented Mar 20, 2019

\cc @shahabhijeet

@anuchandy
Copy link
Member

anuchandy commented Mar 20, 2019 •
edited
Loading

sync-ed with @shahabhijeet on this. The process to onboard .NET sdks for new RP is in progress. For now we can consider it unblocked and new RPs will be manually onboarded. Ref https://github.com/Azure/AzNetSdkTools/issues/141

@anuchandy anuchandy merged commit dc95e65 into Azure:master Mar 21, 2019
This was referenced Mar 21, 2019
Merged
Merged
@poadhika poadhika mentioned this pull request Jul 1, 2019
Closed
8 tasks
@poadhika poadhika mentioned this pull request Jul 8, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YazanMSFT @AutorestCI @azuresdkci @anuchandy @ryansbenson

Comments