[ServiceBus] Replacing scaling logs to WebJobs extension methods#53926
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces custom scaling logs in the Service Bus WebJobs extension with standardized WebJobs extension methods (LogFunctionScaleVote and LogFunctionScaleError). The changes update the WebJobs package version to 3.0.42-dev which presumably includes these new logging extension methods.
Key changes:
- Renamed
functionIdparameters tofunctionNamefor consistency with the new logging methods - Replaced
LogInformationandLogWarningcalls with structured logging extension methodsLogFunctionScaleVoteandLogFunctionScaleError - Updated WebJobs package dependency from version 3.0.41 to 3.0.42-dev
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ServiceBusTargetScaler.cs | Renamed _functionId to _functionName; replaced LogInformation with LogFunctionScaleVote for scale vote logging |
| ServiceBusScaleMonitor.cs | Renamed _functionId to _functionName; passed function name to ServiceBusMetricsProvider |
| ServiceBusMetricsProvider.cs | Added _functionName field and constructor parameter; replaced LogWarning calls with LogFunctionScaleError |
| Packages.Data.props | Updated Microsoft.Azure.WebJobs packages from 3.0.41 to 3.0.42-dev |
| NuGet.Config | Added local NuGet package source |
Comments suppressed due to low confidence (1)
sdk/servicebus/Microsoft.Azure.WebJobs.Extensions.ServiceBus/src/Listeners/ServiceBusMetricsProvider.cs:28
- Corrected spelling of 'Subcription' to 'Subscription' in '_mainSubcriptionName'.
private readonly string _mainSubcriptionName;
eb27187 to
8430784
Compare
8430784 to
33eafcc
Compare
cc28200 to
9d0de62
Compare
|
Hi @alrod. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @alrod. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
|
/reopen |
9d0de62 to
a4bf399
Compare
a4bf399 to
eab0c46
Compare
eab0c46 to
104b8f3
Compare
104b8f3 to
a4f5ba3
Compare
a4f5ba3 to
fac4dca
Compare
Summary
Replace direct
LogWarningcalls in the ServiceBus scaling extensions with standardizedLogFunctionScaleWarningWebJobs extension method.This enables the Scale Controller's OpenTelemetry logger to intercept scaling warning events (EventId 8003) and forward them to the customer's Application Insights, providing visibility into connectivity errors during scaling.
Changes
functionIdconstructor parameter; replacedLogWarningwithLogFunctionScaleWarningfor all error/warning logging pathsfunctionIdtoServiceBusMetricsProviderfunctionIdtoServiceBusMetricsProviderPhase 2 (follow-up)
Migrating the
LogInformationscale vote detail logs toLogFunctionScaleVotewill follow once azure-webjobs-sdk #3189 ships (changes vote log level from Debug to Information).Context
Part of the Scale Controller App Insights logging feature (AAPT-Antares-ScaleController PR #14140160).
Related PRs: