[EventHubs] Replacing scaling logs to WebJobs extension methods#53925
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces custom scaling logs with WebJobs extension methods to standardize logging for EventHubs scaling operations.
- Refactored logging in EventHubsTargetScaler to use
LogFunctionScaleVoteextension method - Updated error logging in EventHubMetricsProvider to use
LogFunctionScaleErrorextension method - Removed redundant try-catch blocks that were previously used only for logging warnings
- Updated Microsoft.Azure.WebJobs package dependencies to version 3.0.42-dev to enable the new logging extension methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| EventHubsTargetScaler.cs | Consolidated two separate log statements into a single LogFunctionScaleVote call with concatenated details string |
| EventHubMetricsProvider.cs | Replaced LogWarning with LogFunctionScaleError and removed try-catch blocks that only logged warnings without handling exceptions |
| Packages.Data.props | Updated Microsoft.Azure.WebJobs packages to version 3.0.42-dev to support new logging extension methods |
| NuGet.Config | Added local package source for development/testing purposes |
076ca2a to
be2e16a
Compare
be2e16a to
729774e
Compare
|
Hi @alrod. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @alrod. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
|
/reopen |
729774e to
f879e2d
Compare
f879e2d to
da64a3d
Compare
da64a3d to
a639788
Compare
a639788 to
1083ea8
Compare
Summary
Replace direct
LogWarningcalls in the EventHubs scaling extensions with standardizedLogFunctionScaleWarningWebJobs extension method.This enables the Scale Controller's OpenTelemetry logger to intercept scaling warning events (EventId 8003) and forward them to the customer's Application Insights, providing visibility into connectivity errors during scaling.
Changes
LogWarningwithLogFunctionScaleWarningfor partition info and checkpoint error loggingPhase 2 (follow-up)
Migrating the
LogInformationscale vote detail logs toLogFunctionScaleVotewill follow once azure-webjobs-sdk #3189 ships (changes vote log level from Debug to Information).Context
Part of the Scale Controller App Insights logging feature (AAPT-Antares-ScaleController PR #14140160).
Related PRs: