Exclude internal types #53123
Merged
Exclude internal types #53123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where internal types with Pipeline properties were being auto-instrumented when they shouldn't be. The change modifies the instrumentation logic to only instrument public types that have a Pipeline property, excluding internal types from automatic instrumentation.
Key Changes
- Added a visibility check to exclude internal types from instrumentation
- Added test coverage for the non-public type exclusion behavior
- Added test infrastructure with both public and internal type examples
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/core/Azure.Core.TestFramework/src/Instrumentation/InstrumentResultInterceptor.cs | Modified instrumentation logic to check type.IsPublic before instrumenting types with Pipeline properties |
| sdk/core/Azure.Core.TestFramework/tests/ClientTestBaseTests.cs | Added test to verify internal types are not auto-instrumented |
| sdk/core/Azure.Core.TestFramework/src/Shared/TestClient.cs | Added test infrastructure with InternalType class and methods to support the new test case |
jorgerangel-msft
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #53111