Add subclient property interceptor support #53111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for subclient property interceptor functionality in the Azure.Core.TestFramework by expanding the conditions that determine when result instrumentation should be applied to client objects.
- Extends the client detection logic to include objects with a "Pipeline" property, indicating they are subclient instances
- Updates the conditional logic in the
InstrumentResultInterceptor.Interceptmethod to handle subclient scenarios
sdk/core/Azure.Core.TestFramework/src/Instrumentation/InstrumentResultInterceptor.cs
Outdated
Show resolved
Hide resolved
christothes
reviewed
Oct 9, 2025
sdk/core/Azure.Core.TestFramework/src/Instrumentation/InstrumentResultInterceptor.cs
Show resolved
Hide resolved
christothes
approved these changes
Oct 9, 2025
This was referenced Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53109