Skip to content

Add setter for collection-type property during safe flatten to avoid massive breaking changes #52596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

Add setter for collection-type property during safe flatten to avoid massive breaking changes #52596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d2a40e
Add setter for collection-type property during safe flatten to avoid …
live1206 Sep 12, 2025
c93e7cd
revert generated code
live1206 Sep 12, 2025
ff880cc
regen test
live1206 Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...-client-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/PropertyHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,7 @@ public static MethodBodyStatement BuildGetter(bool? includeGetterNullCheck, Prop

public static MethodBodyStatement? BuildSetterForSafeFlatten(bool includeSetterCheck, ModelProvider innerModel, PropertyProvider internalProperty, PropertyProvider innerProperty)
{
if (innerProperty.Type.IsCollection)
{
return null;
}

// To not introduce breaking change, for collection types, we keep the setter for collection-type properties during safe flatten.
var isOverriddenValueType = IsOverriddenValueType(innerProperty);
var setter = new List<MethodBodyStatement>();
var internalPropertyExpression = This.Property(internalProperty.Name);
Expand Down
4 changes: 4 additions & 0 deletions ...-mgmt/generator/TestProjects/Local/Mgmt-TypeSpec/src/Generated/BarSettingsResourceData.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.