[Storage][DataMovement] Fixed potential incorrect resource names for upload transfers #52491
+80
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalauzon-msft
requested review from
amnguye,
jaschrep-msft,
nickliu-msft and
seanmcc-msft
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where upload transfers could produce incorrect resource names when a path with a trailing directory separator is passed to LocalFilesStorageResourceProvider.FromDirectory. The fix ensures consistent path handling by trimming trailing separators in the LocalDirectoryStorageResourceContainer constructor.
Key Changes
- Trimmed trailing directory separators in
LocalDirectoryStorageResourceContainerconstructor - Refactored path computation logic in
TransferJobInternalto use a centralized helper method - Added comprehensive test coverage for trailing slash scenarios
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/Azure.Storage.DataMovement/src/LocalDirectoryStorageResourceContainer.cs | Added path trimming logic to constructor |
| sdk/storage/Azure.Storage.DataMovement/src/TransferJobInternal.cs | Refactored path computation into helper method |
| sdk/storage/Azure.Storage.DataMovement/tests/LocalDirectoryStorageResourceTests.cs | Updated tests to verify trimming behavior |
| sdk/storage/Azure.Storage.DataMovement/tests/Shared/StartTransferUploadDirectoryTestBase.cs | Added test for upload with trailing slash |
| sdk/storage/Azure.Storage.DataMovement/tests/Shared/StartTransferDirectoryDownloadTestBase.cs | Added test for download with trailing slash |
| sdk/storage/Azure.Storage.DataMovement/tests/Shared/TransferValidator.Local.cs | Added path trimming for consistency |
| sdk/storage/Azure.Storage.DataMovement.Blobs/tests/BlobContainerClientExtensionsTests.cs | Fixed test to use trimmed paths |
| Multiple CHANGELOG.md files | Added bug fix entry |
| Multiple assets.json files | Updated asset tags |
amnguye
approved these changes
Sep 9, 2025
|
/azp run net - storage - datamovement - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failures are known or flakey. Will override |
|
/check-enforcer override |
jalauzon-msft
added a commit
to jalauzon-msft/azure-sdk-for-net
that referenced
this pull request
Sep 10, 2025
…upload transfers (Azure#52491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where if a path with a trailing path separator was passed to
LocalFilesStorageResourceProvider.FromDirectoryduring an upload transfer, the destination resource names may be missing the first character. This was because some path parsing logic assumed the path did not end with a trailing separator. This fixes the issue by always trimming the end of the path when constructingLocalDirectoryStorageResourceContainer.Also added another change in
TransferJobInternalto harden the logic during enumeration for the same case. While either change would address the issue, this should harden against future issues or missed cases.