Skip to content

[Cogs Face] Generate latest Face SDK from Swagger, including the Snapshot features with latest changes.#5185

Merged
dsgouda merged 1 commit intoAzure:masterfrom
lebronJ:siqliu/updateFaceSnapshotSDK
Jan 29, 2019
Merged

[Cogs Face] Generate latest Face SDK from Swagger, including the Snapshot features with latest changes.#5185
dsgouda merged 1 commit intoAzure:masterfrom
lebronJ:siqliu/updateFaceSnapshotSDK

Conversation

@lebronJ
Copy link
Copy Markdown
Contributor

@lebronJ lebronJ commented Jan 29, 2019

Regenerate Face SDK with latest spec Azure/azure-rest-api-specs#5094 (some minor documentation changes), this is to apply refinements on our last PR #5168.

The <br />s are by design, because without these there will be no line breaks in Swagger generated API reference (currently looks good with the <br />s).

BTW, there are already <br />s in other .NET SDKs in this repo, eg. here.

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@lebronJ
Copy link
Copy Markdown
Contributor Author

lebronJ commented Jan 29, 2019

@dsgouda This is a follow up PR for Face API snapshot feature, may I ask for your review on this? Thanks.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 433d41f into Azure:master Jan 29, 2019
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants