Skip to content

[Cogs Face] Generate latest Face SDK from Swagger, including the Snapshot features of Face API.#5168

Merged
dsgouda merged 4 commits intoAzure:masterfrom
lebronJ:siqliu/faceNETSDKSnapshot
Jan 25, 2019
Merged

[Cogs Face] Generate latest Face SDK from Swagger, including the Snapshot features of Face API.#5168
dsgouda merged 4 commits intoAzure:masterfrom
lebronJ:siqliu/faceNETSDKSnapshot

Conversation

@lebronJ
Copy link
Contributor

@lebronJ lebronJ commented Jan 23, 2019

Regenerate Face SDK with latest spec Azure/azure-rest-api-specs#5074

Hopefully this can take short time and catch our rollout (started on Jan 21st and will last a week) timeline.
(This should also upgrade the documentation to Face .NET SDK documentation.)

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Jan 23, 2019

@lebronJ Please join the Azure org on github here to kick off the build.

@lebronJ
Copy link
Contributor Author

lebronJ commented Jan 24, 2019

@lebronJ Please join the Azure org on github here to kick off the build.

@dsgouda Thanks. I think I am already a member of Azure org, could you please help show me how to kick off this build? (BTW, as I know this build is not mandatory).

And who will be the second reviewer? Thanks!

image

@dsgouda
Copy link
Contributor

dsgouda commented Jan 24, 2019

@azuresdkci Test this please

@dsgouda
Copy link
Contributor

dsgouda commented Jan 24, 2019

@azuresdkci retest this please

@dsgouda dsgouda changed the base branch from psSdkJson6 to master January 24, 2019 18:10
@dsgouda
Copy link
Contributor

dsgouda commented Jan 24, 2019

@lebronJ Please note that we have switched our default branch to master instead of psSdkJson6 now

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit cb427a2 into Azure:master Jan 25, 2019
dsgouda added a commit that referenced this pull request Jan 25, 2019
…the Snapshot features of Face API. (#5168)"

This reverts commit cb427a2.
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
…shot features of Face API. (Azure#5168)

* Update README.md

Updating header

* Generate latest Face SDK from Swagger, including the Snapshot features of Face API.

* Add tests for Snapshot interfaces.

* Bump up the versions in Face.csproj and Properties/AssemblyInfo.cs
azure-sdk pushed a commit that referenced this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants