Skip to content

Generate SDK for new API version#5151

Merged
dsgouda merged 8 commits intoAzure:psSdkJson6from
filizt:blueprint-sdk-update
Jan 19, 2019
Merged

Generate SDK for new API version#5151
dsgouda merged 8 commits intoAzure:psSdkJson6from
filizt:blueprint-sdk-update

Conversation

@filizt
Copy link
Contributor

@filizt filizt commented Jan 17, 2019

Description


Blueprint API change PRs
Azure/azure-rest-api-specs#4590
Azure/azure-rest-api-specs#4945

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Blueprint API change PRs
Azure/azure-rest-api-specs#4590
Azure/azure-rest-api-specs#4945

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code generated using a generate.ps1 script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a new API version, the Nuget major version needs to be bumped too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filizt As we discussed offline, please bump this version to 1.8.0-preview (please note the casing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda after out email thread, updating the version as 0.10.0-preview

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Jan 18, 2019

Will merge on CIs passing

azure-sdk-for-net.client can be ignored

@dsgouda dsgouda merged commit bf7af84 into Azure:psSdkJson6 Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments