Skip to content

Support managementGroup and subscription scopes in Blueprint API version 2018-11-01#4945

Merged
praries880 merged 4 commits intoAzure:masterfrom
filizt:BP-ModelingUpdate
Jan 14, 2019
Merged

Support managementGroup and subscription scopes in Blueprint API version 2018-11-01#4945
praries880 merged 4 commits intoAzure:masterfrom
filizt:BP-ModelingUpdate

Conversation

@filizt
Copy link
Contributor

@filizt filizt commented Dec 19, 2018 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-portal-comment
Copy link

openapi-portal-comment bot commented Dec 19, 2018

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#4158

@azuresdkci
Copy link
Contributor

azuresdkci commented Dec 19, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Dec 19, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Dec 19, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3870

@filizt filizt changed the title Bp modeling update Adding new API version to Blueprint API Dec 19, 2018
@filizt filizt changed the title Adding new API version to Blueprint API Modeling Blueprint API to handle both both managementGroup and subscription scopes Dec 19, 2018
@filizt filizt changed the title Modeling Blueprint API to handle both both managementGroup and subscription scopes Support managementGroup and subscription scopes in Blueprint API version 2018-11-01 Dec 19, 2018
@hovsepm hovsepm added Does-Not-Validate DoNotMerge <valid label in PR review process> use to hold merge after approval and removed DoNotMerge <valid label in PR review process> use to hold merge after approval Does-Not-Validate labels Dec 19, 2018
@praries880 praries880 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. labels Jan 2, 2019
ravbhatnagar
ravbhatnagar reviewed Jan 9, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, just one note.

...int/resource-manager/Microsoft.Blueprint/preview/2018-11-01-preview/blueprintDefinition.json Outdated
"nextLinkName": "nextLink"
}
}
},
Copy link
Contributor

@ravbhatnagar ravbhatnagar Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the operations API been removed?

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Jan 10, 2019

@filizt - Why is the operations API linter rule suppressed? Your RP should still expose the available operations

@haitch
Copy link
Contributor

haitch commented Jan 11, 2019

@ravbhatnagar because we are extension resource, the url path include /providers/Microsoft.Management, then the linter complain about multiple resource providers.

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Jan 11, 2019

confirmed with @haitch and the operations API is present. The suppression is needed due to the multiple provider segments and linter throwing an issue for that.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 11, 2019
@jhendrixMSFT
Copy link
Member

jhendrixMSFT commented Jan 11, 2019

@AutorestCI regenerate azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jan 11, 2019
Merged
@praries880 praries880 removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jan 12, 2019
@praries880 praries880 merged commit 4b06e4d into Azure:master Jan 14, 2019
@filizt filizt mentioned this pull request Jan 17, 2019
Merged
9 tasks
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Feb 6, 2019
@filizt @AnuTalluri
Support managementGroup and subscription scopes in Blueprint API vers…
0622d4c 
…ion 2018-11-01 (Azure#4945)

* Add 2017-11-11-preview files

* BP 2018-11-01-preview updates: modeling blueprint to both managementGroup and subscription

* Update readme files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@praries880 praries880 praries880 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@praries880 praries880

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@filizt @AutorestCI @azuresdkci @ravbhatnagar @haitch @jhendrixMSFT @praries880 @hovsepm @kpajdzik

Comments