Add Azure Batch DataPlane SDK version 10#5081
Merged
shahabhijeet merged 5 commits intoAzure:psSdkJson6from Dec 14, 2018
Merged
Conversation
Member
Author
- Update retry policies to honor retry-after header if returned
from the service.
- Added a maximum duration for ExponentialRetry so that it need not
back off exponentially forever.
matthchr
force-pushed
the
feature/sdk10
branch
from
760316d to
d0fa974
Compare
Member
Author
|
This also deletes the extra packages.config file which was causing #4880 |
Member
|
Looks good to me. |
bgklein
reviewed
Dec 13, 2018
| - `ExponentialRetry` supports a backoff cap, via the `MaxBackoff` property. | ||
|
|
||
| ### Bug fixes | ||
| - The built in retry policies `ExponentialRetry` and `LinearRetry` now correctly retry on HTTP status code `429` and honor the `retry-after` header. |
Contributor
|
LGTM as well |
shahabhijeet
suggested changes
Dec 14, 2018
| <PackageId>Microsoft.Azure.Batch</PackageId> | ||
| <Description>This client library provides access to the Microsoft Azure Batch service.</Description> | ||
| <Version>9.0.1</Version> | ||
| <Version>10.0.0</Version> |
Contributor
There was a problem hiding this comment.
@matthchr why a major version bump?
Can you also release notes?
Is the major version due to breaking changes or underlying API change?
Member
Author
There was a problem hiding this comment.
I did release notes, they're included in the PR.
There are breaking changes both in the SDK and in the underlying API, which is why it's a major version bump. The release notes outlines what changed and what breaks there were.
shahabhijeet
approved these changes
Dec 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.For SDK team: