Add Batch dataplane API version 2018-12-01.8.0 by matthchr · Pull Request #4795 · Azure/azure-rest-api-specs

matthchr · 2018-12-05T18:45:49Z

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

This is a data plane API so ARM review is not required.

I tried to run the linter here: https://portal.azure-devex-tools.com/app/tools/linter but it just hung on "still working!" forever.
I also tried to run this: https://portal.azure-devex-tools.com/app/tools/static-validation/static/errors/default pointing at https://github.com/matthchr/azure-rest-api-specs/tree/feature/batch-dataplane-2018-12/specification/batch/data-plane/Microsoft.Batch/stable/2018-12-01.8.0 and I also got an error "Sorry something went wrong!"

I did run the azure validator manually though and things looked okay (there's some warnings but they basically don't seem to apply to data-plane)

openapi-portal-comment · 2018-12-05T18:45:52Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-05T18:46:24Z

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#799

AutorestCI · 2018-12-05T18:46:29Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-05T18:46:31Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#4031

AutorestCI · 2018-12-05T18:46:48Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-12-05T18:46:57Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4416

azuresdkci · 2018-12-05T18:48:28Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-05T18:51:06Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3673

anuchandy · 2018-12-05T19:04:09Z

@matthchr I will talk to owners of the devex tool on the issues you faced.

Could you take a look at model (example) validation https://travis-ci.org/Azure/azure-rest-api-specs/jobs/463987019?

matthchr · 2018-12-05T19:16:47Z

@anuchandy - I will fix the example validation issues and update the PR

matthchr · 2018-12-05T19:29:09Z

The examples should be fixed now

matthchr · 2018-12-05T20:22:39Z

I fixed the original issue with the model validator, but am now getting a different one which seems very unclear to me. See: https://travis-ci.org/Azure/azure-rest-api-specs/jobs/464004216

operationId: Application_Get
scenario: Get applications
source: request
responseCode: ALL
severity: 0
errorCode: REQUIRED
errorDetails:
  code: REQUIRED
  message: Value is required but was not provided
  path: >-
    /applications/{applicationId}/applicationId/paths//applications/{applicationId}/get/parameters/0

It's not clear to me what the actual problem is...

dlepow · 2018-12-06T00:38:04Z

specification/batch/data-plane/Microsoft.Batch/stable/2018-12-01.8.0/BatchService.json

@matthchr - Matt, sorry, can you please update this description to change the incorrect doc link? I suggest:
"description": "This property is mutually exclusive with other ImageReference properties. The virtual machine image must be in the same region and subscription as the Azure Batch account. For more details, see https://docs.microsoft.com/azure/batch/batch-custom-images."

@dlepow did you put this on the wrong line?

I think I found where it was meant to be though -- I've fixed the docs there

@matthchr - Thanks. When I commented before the GitHub UI was a bit flaky with the large file, so I might have selected the wrong place.

matthchr · 2018-12-07T18:06:07Z

@anuchandy I have confirmed that the URLs should contain HTTPS (at least, in the code generated by AutoRest you must set the URL to https://<account>.<region>.batch.azure.com). Given that, I think it makes sense to leave the examples with the HTTPS, as I am pretty sure it's supposed to be there.

Is there anything else that needs to be fixed, or is this good to merge?

anuchandy · 2018-12-10T08:15:51Z

@sergey-shandar - do you think this is a bug in OAV? OR should "https" has to be removed from examples? we may want to set a guideline for service team here, what I understand from our hallway talk is - "the swagger scheme part says it's https and as per http convention, host name does not contain protocol." Can you please confirm?

Tracked here: Azure/oav#368

- Add batchUrl parameter. - Rename "ocp-data" to "ocp-date" to correctly reflect what the API actually requires.

matthchr · 2018-12-10T21:39:04Z

@anuchandy - I believe the examples should be fixed now, I removed HTTPS from them

* Prepare for Azure Batch new API version * Add new data plane API version 2018-12-01.8.0 * Fix documentation issues * Fix examples - Add batchUrl parameter. - Rename "ocp-data" to "ocp-date" to correctly reflect what the API actually requires.

azuresdkci assigned anuchandy Dec 5, 2018

azuresdkci requested a review from anuchandy December 5, 2018 18:46

matthchr force-pushed the feature/batch-dataplane-2018-12 branch from 1768ec8 to 939375c Compare December 5, 2018 18:48

AutorestCI mentioned this pull request Dec 5, 2018

[AutoPR batch/data-plane] Add Batch dataplane API version 2018-12-01.8.0 Azure/azure-sdk-for-python#4010

Closed

matthchr mentioned this pull request Dec 5, 2018

Clarify meaning of "Node allocation time" Azure/Batch#25

Closed

dlepow reviewed Dec 6, 2018

View reviewed changes

xingwu1 added 2 commits December 6, 2018 11:04

Prepare for Azure Batch new API version

93e1b2f

Add new data plane API version 2018-12-01.8.0

792c82b

matthchr force-pushed the feature/batch-dataplane-2018-12 branch from e275707 to 9b00f1b Compare December 6, 2018 19:05

Fix documentation issues

00f38c1

matthchr force-pushed the feature/batch-dataplane-2018-12 branch 3 times, most recently from 75930dc to 3f5b3a4 Compare December 7, 2018 18:05

Fix examples

8460714

- Add batchUrl parameter. - Rename "ocp-data" to "ocp-date" to correctly reflect what the API actually requires.

matthchr force-pushed the feature/batch-dataplane-2018-12 branch from 3f5b3a4 to 8460714 Compare December 10, 2018 21:38

anuchandy approved these changes Dec 10, 2018

View reviewed changes

anuchandy merged commit d8805f6 into Azure:master Dec 10, 2018

matthchr deleted the feature/batch-dataplane-2018-12 branch December 11, 2018 21:59

matthchr mentioned this pull request Dec 12, 2018

Add Azure Batch DataPlane SDK version 10 Azure/azure-sdk-for-net#5081

Merged

9 tasks

Comments

Conversation

matthchr commented Dec 5, 2018

Contribution checklist:

Uh oh!

openapi-portal-comment bot commented Dec 5, 2018

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkci commented Dec 5, 2018

Uh oh!

AutorestCI commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

anuchandy commented Dec 5, 2018

Uh oh!

matthchr commented Dec 5, 2018

Uh oh!

matthchr commented Dec 5, 2018

Uh oh!

matthchr commented Dec 5, 2018

Uh oh!

dlepow Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

matthchr Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

matthchr Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

dlepow Dec 6, 2018

Choose a reason for hiding this comment

Uh oh!

matthchr commented Dec 7, 2018

Uh oh!

anuchandy commented Dec 10, 2018

Uh oh!

matthchr commented Dec 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AutorestCI commented Dec 5, 2018 •

edited

Loading

AutorestCI commented Dec 5, 2018 •

edited

Loading

AutorestCI commented Dec 5, 2018 •

edited

Loading

AutorestCI commented Dec 5, 2018 •

edited

Loading

AutorestCI commented Dec 5, 2018 •

edited

Loading

AutorestCI commented Dec 5, 2018 •

edited

Loading