Skip to content

Network SDK november release#5053

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
anton-evseev:network-november-release
Nov 27, 2018
Merged

Network SDK november release#5053
dsgouda merged 2 commits intoAzure:psSdkJson6from
anton-evseev:network-november-release

Conversation

@anton-evseev
Copy link
Copy Markdown
Contributor

@anton-evseev anton-evseev commented Nov 27, 2018

Description

Re-generated SDK based on master (after merging Azure/azure-rest-api-specs#4509)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Nov 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a minor change

src/SDKs/Network/Management.Network/Properties/AssemblyInfo.cs
@@ -8,7 +8,7 @@
[assembly: AssemblyDescription("Provides Microsoft Azure Network management functions for managing the Microsoft Azure Network service.")]

[assembly: AssemblyVersion("19.5.0.0")]
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssemblyVersion must be 19.0.0.0

Copy link
Copy Markdown
Contributor Author

@anton-evseev anton-evseev Nov 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda you okay'd this the last time since that would downgrading
#4981

dsgouda
dsgouda approved these changes Nov 27, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit b48dc7c into Azure:psSdkJson6 Nov 27, 2018
@anton-evseev anton-evseev deleted the network-november-release branch February 15, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anton-evseev @dsgouda