Generated Network SDK based on Swagger's October release#4981
Merged
shahabhijeet merged 2 commits intoAzure:psSdkJson6from Oct 31, 2018
Merged
Generated Network SDK based on Swagger's October release#4981shahabhijeet merged 2 commits intoAzure:psSdkJson6from
shahabhijeet merged 2 commits intoAzure:psSdkJson6from
Conversation
Contributor
Author
|
@MikhailTryakhov @dsgouda please review if assembly version change is correct [assembly: AssemblyVersion("19.5.0.0")]
-[assembly: AssemblyFileVersion("19.5.1.0")]
+[assembly: AssemblyFileVersion("19.6.0.0")] |
dsgouda
suggested changes
Oct 31, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from a minor comment
| @@ -8,7 +8,7 @@ | |||
| [assembly: AssemblyDescription("Provides Microsoft Azure Network management functions for managing the Microsoft Azure Network service.")] | |||
|
|
|||
| [assembly: AssemblyVersion("19.5.0.0")] | |||
Contributor
There was a problem hiding this comment.
Please set AssemblyVersion to 19.0.0.0
AssemblyFileVersion is correct
Contributor
There was a problem hiding this comment.
can we easily downgrade this version?
Contributor
There was a problem hiding this comment.
Correcting myself, please leave AssemblyVersion unchanged
shahabhijeet
approved these changes
Oct 31, 2018
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.