Skip to content

Bump the version to 1.24.0-preview#5043

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
NMijat1024:version-bump
Nov 26, 2018
Merged

Bump the version to 1.24.0-preview#5043
dsgouda merged 1 commit intoAzure:psSdkJson6from
NMijat1024:version-bump

Conversation

@NMijat1024
Copy link
Copy Markdown
Contributor

@NMijat1024 NMijat1024 commented Nov 21, 2018 •
edited
Loading

Because #5008 was merged after publishing the 1.23.0-preview, I need to change the version.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Nov 21, 2018

@NMijat1024 Please resolve merge conflicts

dsgouda
dsgouda suggested changes Nov 21, 2018
View reviewed changes
src/SDKs/SqlManagement/Management.Sql/Microsoft.Azure.Management.Sql.csproj Outdated
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the change being introduced in this package?

Copy link
Copy Markdown
Contributor Author

@NMijat1024 NMijat1024 Nov 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the reason for this PR on the top of the description

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Nov 21, 2018

Per our guidelines, please squash commits into a single commit and update the PR. Looks good for the most part but curious if this is a version bump without any changes

@NMijat1024
Copy link
Copy Markdown
Contributor Author

NMijat1024 commented Nov 21, 2018

Resolved @dsgouda

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Nov 21, 2018

We should probably be using feature branches to avoid such confusion. I also see that there is this PR open, should it be merged before or after this PR.

@NMijat1024
Copy link
Copy Markdown
Contributor Author

NMijat1024 commented Nov 21, 2018

I guess it is okay to merge this PR first, because nuget package version 1.23.0-preview is already published.

dsgouda
dsgouda approved these changes Nov 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge on CIs passing

@NMijat1024
Copy link
Copy Markdown
Contributor Author

NMijat1024 commented Nov 21, 2018

@dsgouda Just wait to squash commits. :)

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Nov 21, 2018

@NMijat1024 please resolve conflicts and update the PR

dsgouda
dsgouda approved these changes Nov 26, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 0b7c5b4 into Azure:psSdkJson6 Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NMijat1024 @dsgouda @jaredmoo