Skip to content

Collation argument for create managed instance #5008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 1 commit into from
Nov 19, 2018
Merged

Collation argument for create managed instance #5008

dsgouda merged 1 commit into from
Nov 19, 2018

Conversation

@NMijat1024
Copy link
Contributor

@NMijat1024 NMijat1024 commented Nov 9, 2018 •
edited
Loading

Description

Azure/azure-rest-api-specs#4314

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Nov 12, 2018

@NMijat1024 Please squash your commits into a single commit

dsgouda
dsgouda suggested changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please squash commits

@dsgouda
Copy link
Contributor

dsgouda commented Nov 12, 2018

@azuresdkci retest this please

@NMijat1024
Copy link
Contributor Author

NMijat1024 commented Nov 15, 2018

@dsgouda Looks better now

@NMijat1024
Copy link
Contributor Author

NMijat1024 commented Nov 15, 2018

@azuresdkci retest this please

dsgouda
dsgouda suggested changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredmoo just wondering if you'd like working on the same version in a branch and merging it all together to psSdkJson6. I see these PRs are for the same unpublished version of the SDK

src/SDKs/SqlManagement/Management.Sql/Generated/Models/DatabaseBlobAuditingPolicy.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this autogenerated or edited by hand?

Copy link
Contributor Author

@NMijat1024 NMijat1024 Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated.

Copy link
Contributor

@dsgouda dsgouda Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy Is such encoding expected in generated code?

Copy link
Contributor

@jaredmoo jaredmoo Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem? It has changed < and > to { and }. The braces don't need to be xml escaped.

src/SDKs/SqlManagement/Management.Sql/Generated/SqlManagementClient.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changes introduced here to the PackageReleaseNotes in csproj

Copy link
Contributor Author

@NMijat1024 NMijat1024 Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also auto generated. Should I revert all the changes that are not tied to my feature?

Copy link
Contributor

@dsgouda dsgouda Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not revert any files.
Since autogenerating from the latest changes introduces these changes, they must be recorded in the PackageReleaseNotes
Please consult with @jaredmoo regarding this

Copy link
Contributor

@jaredmoo jaredmoo Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, did autorest remove this constructor?

Copy link
Contributor Author

@NMijat1024 NMijat1024 Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

@NMijat1024 NMijat1024 Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy Here is the PR which used preview version of autorest. #5029

Copy link
Contributor

@dsgouda dsgouda Nov 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that deletes the constructor too

Copy link
Contributor Author

@NMijat1024 NMijat1024 Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, shall we get this merged? @dsgouda @jaredmoo

Copy link
Contributor

@jaredmoo jaredmoo Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already signed off several days ago, I don't have the ability to merge.

Copy link
Contributor

@dsgouda dsgouda Nov 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure this doesn't adversely affect customers. SInce this is preview, it should be OK to merge this

jaredmoo
jaredmoo reviewed Nov 15, 2018
View reviewed changes
Copy link
Contributor

@jaredmoo jaredmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PackageReleaseNotes in Microsoft.Azure.Management.Sql.csproj

src/SDKs/SqlManagement/Management.Sql/Generated/Models/DatabaseBlobAuditingPolicy.cs Outdated
Copy link
Contributor

@jaredmoo jaredmoo Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem? It has changed < and > to { and }. The braces don't need to be xml escaped.

src/SDKs/SqlManagement/Management.Sql/Generated/SqlManagementClient.cs Outdated
Copy link
Contributor

@jaredmoo jaredmoo Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, did autorest remove this constructor?

dsgouda
dsgouda reviewed Nov 15, 2018
View reviewed changes
...Ks/SqlManagement/Management.Sql/Generated/IDatabaseVulnerabilityAssessmentScansOperations.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredmoo not just the constructor but these changes too

Copy link
Contributor

@jaredmoo jaredmoo Nov 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like autorest is being weird and shuffling the methods around the file

@NMijat1024
Copy link
Contributor Author

NMijat1024 commented Nov 15, 2018

@jaredmoo @dsgouda Package release notes are updated.

dsgouda
dsgouda approved these changes Nov 19, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 8e0f068 into Azure:psSdkJson6 Nov 19, 2018
@NMijat1024 NMijat1024 mentioned this pull request Nov 21, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@fearthecowboy fearthecowboy fearthecowboy left review comments

@jaredmoo jaredmoo jaredmoo approved these changes

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NMijat1024 @dsgouda @fearthecowboy @jaredmoo