feature/repairswagger by sumitabarahmand · Pull Request #5000 · Azure/azure-sdk-for-net

sumitabarahmand · 2018-11-04T07:33:40Z

Description

SDK changes for the new Alert Repair admin operation
PR for the spec: Azure/azure-rest-api-specs#4084

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

sumitabarahmand · 2018-11-04T07:35:39Z

@bganapa and @deathly809
Spec PR link:
Azure/azure-rest-api-specs#4084

deathly809 · 2018-11-05T17:45:28Z

@sumitabarahmand After your spec PR has been merged please regenerate from merged spec.

dsgouda

When ready, please squash commits into a single commit

dsgouda · 2018-11-05T18:13:34Z

...astructureInsights.Admin/Microsoft.AzureStack.Management.InfrastructureInsights.Admin.csproj

Please update PackageReleaseNotes

please mention that repair api is supported only on AzureStack 1811 +

@dsgouda can we add a checklist item in the PR saying 'I have updated relevant package release notes' ?

I see that you already mention about 1811 :)

bganapa · 2018-11-05T18:58:08Z

@dsgouda GitHub has the option of squashing the commits when you are merging the PR. We are ok for you to do this. Pls lets us know if you still want us to manually squash the commits

shahabhijeet · 2018-11-07T21:00:05Z

@bganapa we lately started seeing issue with merges when we use squash/merge options, especially while trying to merge into other branches.
So we have now started being very particular on not having really long commit history. I understand 2-3 commits. But when you go beyond that, we ask RPs to clean up the commit history.
That is just something that helps us as well as you to have clean commit history, especially when we need to revert changes or when we have to create a branch out of a commit.
So help us to maintain the commit history in a clean state.

bganapa · 2018-11-08T18:54:25Z

Yes, we will squash the commits and update this PR once the specs PR is merged Azure/azure-rest-api-specs#4084

deathly809 · 2018-11-10T00:27:29Z

@sumitabarahmand Your REST spec has been merged, please regenerate and make requested changes above. Thanks!

dsgouda · 2018-11-12T22:27:02Z

@azuresdkci retest this please

bganapa · 2018-11-13T18:06:20Z

@sumitabarahmand could you please squash the commits..
Can you please add a release note saying the repair api is supported azurestack 1811 +

fix build issues Add SDK unit test for Alert Repair rabase and resolve conflicts revert generate changes update SDK based on updated alert spec remove auto generated metadata update assembly version generate SDK with latest spec add autogenerated spec metadata generate SDK from merged specs update release notes

dsgouda

Few minor comments

dsgouda · 2018-11-14T17:14:25Z

...astructureInsights.Admin/Microsoft.AzureStack.Management.InfrastructureInsights.Admin.csproj

                Preview release of the InfrastructureInsights administrator SDK which allows administrators  
                1) View the health of their AzureStack stamp resources 
                2) View and manage alerts
+                Repair API is supported in azurestack 1811+


nit: please stick to numbering scheme

@dsgouda Should we only put in new things for release notes?

Ideally yes, that way users know what changed from the last version

Just updated the PR.

dsgouda · 2018-11-14T17:18:55Z

...ack/Admin/InfrastructureInsightsAdmin/InfrastructureInsights.Admin/Generated/Models/Alert.cs

        /// <param name="closedByUserAlias">User alias who closed the
        /// alert.</param>
-        public Alert(string id = default(string), string name = default(string), string type = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), string location = default(string), string closedTimestamp = default(string), string createdTimestamp = default(string), IList<IDictionary<string, string>> description = default(IList<IDictionary<string, string>>), string faultId = default(string), string alertId = default(string), string faultTypeId = default(string), string lastUpdatedTimestamp = default(string), IDictionary<string, string> alertProperties = default(IDictionary<string, string>), IList<IDictionary<string, string>> remediation = default(IList<IDictionary<string, string>>), string resourceRegistrationId = default(string), string resourceProviderRegistrationId = default(string), string severity = default(string), string state = default(string), string title = default(string), string impactedResourceId = default(string), string impactedResourceDisplayName = default(string), string closedByUserAlias = default(string))
+        /// <param name="hasValidRemediationAction">Indicates if the alert can


Was this autogenerated or hand edited?

Autogenerated

dsgouda

LGTM

dsgouda · 2018-11-14T17:48:03Z

Will merge on CIs passing

sumitabarahmand mentioned this pull request Nov 4, 2018

Feature/repairswagger: Adding powershell cmdlet for repair alert Azure/azure-powershell#7742

Merged

8 tasks

dsgouda added the spec-not-merged label Nov 5, 2018

dsgouda suggested changes Nov 5, 2018

View reviewed changes

bganapa mentioned this pull request Nov 8, 2018

Add spec for alert repair/remediate Azure/azure-rest-api-specs#4084

Merged

10 tasks

sumitabarahmand force-pushed the feature/repairswagger branch from 73cc042 to 6f95e42 Compare November 14, 2018 15:40

sumitabarahmand force-pushed the feature/repairswagger branch from 8c57f1e to 6b0c5f6 Compare November 14, 2018 17:14

dsgouda suggested changes Nov 14, 2018

View reviewed changes

dsgouda added Changes Requested and removed spec-not-merged labels Nov 14, 2018

updated release notes

5049898

dsgouda approved these changes Nov 14, 2018

View reviewed changes

dsgouda removed the Changes Requested label Nov 14, 2018

bganapa approved these changes Nov 14, 2018

View reviewed changes

dsgouda merged commit 73026ac into Azure:psSdkJson6 Nov 14, 2018

Conversation

sumitabarahmand commented Nov 4, 2018

Description

SDK changes for the new Alert Repair admin operation PR for the spec: Azure/azure-rest-api-specs#4084

Uh oh!

sumitabarahmand commented Nov 4, 2018

Uh oh!

deathly809 commented Nov 5, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bganapa commented Nov 5, 2018

Uh oh!

shahabhijeet commented Nov 7, 2018

Uh oh!

bganapa commented Nov 8, 2018

Uh oh!

deathly809 commented Nov 10, 2018

Uh oh!

dsgouda commented Nov 12, 2018

Uh oh!

bganapa commented Nov 13, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Nov 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SDK changes for the new Alert Repair admin operation
PR for the spec: Azure/azure-rest-api-specs#4084