Feature/repairswagger: Adding powershell cmdlet for repair alert #7742

sumitabarahmand · 2018-11-04T09:39:14Z

Description

Adding powershell cmdlet for repair alert
Spec PR: Azure/azure-rest-api-specs#4084
SDK PR: Azure/azure-sdk-for-net#5000

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate change log has been updated
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- the changes have gone through a cmdlet design review (Microsoft internal partners only)
- the cmdlet markdown files were generated using the platyPS module

sumitabarahmand · 2018-11-04T09:40:16Z

@bganapa and @deathly809
Spec: Azure/azure-rest-api-specs#4084
SDK: Azure/azure-sdk-for-net#5000

adxsdkps · 2018-11-04T09:41:04Z

Can one of the admins verify this patch?

deathly809 · 2018-11-05T15:53:09Z

Will review after SDK is merged.

maddieclayton · 2018-11-05T22:23:32Z

@azuresdkci Add to whitelist

bganapa · 2018-11-14T19:19:11Z

@sumitabarahmand please update this PR once the SDK PR
Azure/azure-sdk-for-net#5000 is merged and published.

sumitabarahmand · 2018-11-15T05:14:00Z

The SDK is published: https://azuresdkci.westus2.cloudapp.azure.com/view/NetCore-SDK/job/NetCore-SDK-Publish/180/

deathly809 · 2018-11-15T18:07:25Z

@maddieclayton Seems the website tests failed,

Skipped  Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestRestoreDeletedWebAppToExisting
[xUnit.net 00:00:13.89]     Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestGetDeletedWebApp [FAIL]

and for default

0.9999002s ✘  Microsoft.Azure.Commands.Websites.Test.ScenarioTests.WebAppBackupRestoreTests.TestGetDeletedWebApp

bganapa · 2018-11-15T18:10:09Z

ps-sign https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1556/console

src/StackAdmin/Azs.InfrastructureInsights.Admin/Tests/src/Alert.Tests.ps1

bganapa · 2018-11-15T21:32:33Z

@sumitabarahmand
can you please edit these files for module version update
https://github.com/Azure/azure-powershell/blob/preview/src/StackAdmin/Azs.InfrastructureInsights.Admin/Module/Azs.InfrastructureInsights.Admin/Azs.Infrastructureinsights.Admin.psd1#L20
https://github.com/Azure/azure-powershell/blob/preview/src/StackAdmin/AzureStack/AzureStack.psd1#L62

otherwise it looks good to me

bganapa · 2018-11-20T21:48:27Z

ps-sign - https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1563/console

maddieclayton · 2018-11-20T21:49:08Z

@bganapa Can you get @deathly809 to approve as well? His request for changes is blocking merge.

fix spacing add hasvalidremediationaction check for repair tests add changelog and update assembly version reference fix typo update references Update assembly version and added negative unit tests for repair alert fix spacing

sumitabarahmand · 2018-11-21T03:27:00Z

Negative tests are added and all versions are updated.

bganapa · 2018-11-21T18:11:15Z

@maddieclayton Thanks for looking at this PR. @deathly809 is OOF and his concern of adding a negative test case has been addressed now. The previous ps-sign failed due to module version mismatch..
a new one is running now https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/1565/

deathly809 · 2018-11-27T00:42:29Z

@maddieclayton Could you please merge this? Everything looks fine to us.

- Azure#7742 - Azure#7762 - Azure#7911

azuresdkci1x added the needs-review label Nov 4, 2018

deathly809 requested review from bganapa and deathly809 November 5, 2018 15:52

deathly809 added the Azure Stack label Nov 5, 2018

maddieclayton assigned deathly809 Nov 6, 2018

sumitabarahmand force-pushed the feature/repairswagger branch from 16faf5f to c31948d Compare November 14, 2018 18:00

bganapa assigned sumitabarahmand and unassigned deathly809 Nov 14, 2018

bganapa added needs-revision and removed needs-review labels Nov 14, 2018

sumitabarahmand force-pushed the feature/repairswagger branch 2 times, most recently from 3682b28 to ec97de9 Compare November 15, 2018 05:10

deathly809 suggested changes Nov 15, 2018

View reviewed changes

src/StackAdmin/Azs.InfrastructureInsights.Admin/Tests/src/Alert.Tests.ps1 Outdated Show resolved Hide resolved

sumitabarahmand force-pushed the feature/repairswagger branch from fb99c4b to 9626f05 Compare November 20, 2018 03:17

bganapa previously approved these changes Nov 20, 2018

View reviewed changes

bganapa assigned maddieclayton and unassigned sumitabarahmand Nov 20, 2018

bganapa added needs-review and removed needs-revision labels Nov 20, 2018

bganapa assigned sumitabarahmand and unassigned maddieclayton Nov 20, 2018

bganapa added needs-revision and removed needs-review labels Nov 20, 2018

sumitabarahmand dismissed bganapa’s stale review via f8a6841 November 21, 2018 03:15

sumitabarahmand force-pushed the feature/repairswagger branch 2 times, most recently from f8a6841 to 848f935 Compare November 21, 2018 03:18

add powershell module and test for alert repair SDK

bb3da11

fix spacing add hasvalidremediationaction check for repair tests add changelog and update assembly version reference fix typo update references Update assembly version and added negative unit tests for repair alert fix spacing

sumitabarahmand force-pushed the feature/repairswagger branch from b4d5b50 to bb3da11 Compare November 21, 2018 03:23

bganapa previously approved these changes Nov 21, 2018

View reviewed changes

bganapa assigned maddieclayton and unassigned sumitabarahmand Nov 21, 2018

bganapa removed the needs-revision label Nov 21, 2018

maddieclayton assigned deathly809 and unassigned maddieclayton Nov 21, 2018

maddieclayton added the needs-review label Nov 21, 2018

Updating Azs.Fabric.Admin version to 0.3.0 resolving the conflicts

04c30fd

bganapa dismissed their stale review via 04c30fd November 21, 2018 20:34

deathly809 approved these changes Nov 27, 2018

View reviewed changes

maddieclayton merged commit dd84cdd into Azure:preview Nov 27, 2018

This was referenced Nov 28, 2018

[AzureStack] Add help md files for new fabric admin cmdlet #7931

Closed

Updating release notes for the AzureStack release 1.6.0 #7924

Closed

cormacpayne added a commit to cormacpayne/azure-powershell that referenced this pull request Nov 28, 2018

Move changes from the following PRs into AzureRM branch:

d70895e

- Azure#7742 - Azure#7762 - Azure#7911

cormacpayne mentioned this pull request Nov 28, 2018

Move AzureStack changes from preview into AzureRM #7939

Merged

8 tasks

Feature/repairswagger: Adding powershell cmdlet for repair alert #7742

Feature/repairswagger: Adding powershell cmdlet for repair alert #7742

Uh oh!

Conversation

sumitabarahmand commented Nov 4, 2018

Description

Checklist

Uh oh!

sumitabarahmand commented Nov 4, 2018

Uh oh!

adxsdkps commented Nov 4, 2018

Uh oh!

deathly809 commented Nov 5, 2018

Uh oh!

maddieclayton commented Nov 5, 2018

Uh oh!

bganapa commented Nov 14, 2018

Uh oh!

sumitabarahmand commented Nov 15, 2018

Uh oh!

deathly809 commented Nov 15, 2018

Uh oh!

bganapa commented Nov 15, 2018

Uh oh!

Uh oh!

bganapa commented Nov 15, 2018

Uh oh!

bganapa commented Nov 20, 2018

Uh oh!

maddieclayton commented Nov 20, 2018

Uh oh!

sumitabarahmand commented Nov 21, 2018

Uh oh!

bganapa commented Nov 21, 2018

Uh oh!

deathly809 commented Nov 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants